linux-kernel - Re: [PATCH 03/11] fs: exit early in generic_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12bb96b6-1e2e-4f53-b4ea-1fae2500aa21@gmail.com>
Date: Mon, 22 Dec 2025 21:33:04 -0800
From: Chaitanya Kulkarni <ckulkarnilinux@...il.com>
To: Christoph Hellwig <hch@....de>, Christian Brauner <brauner@...nel.org>
Cc: Al Viro <viro@...iv.linux.org.uk>, David Sterba <dsterba@...e.com>,
 Jan Kara <jack@...e.cz>, Mike Marshall <hubcap@...ibond.com>,
 Martin Brandenburg <martin@...ibond.com>, Carlos Maiolino <cem@...nel.org>,
 Stefan Roesch <shr@...com>, Jeff Layton <jlayton@...nel.org>,
 linux-kernel@...r.kernel.org, linux-btrfs@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, gfs2@...ts.linux.dev,
 io-uring@...r.kernel.org, devel@...ts.orangefs.org,
 linux-unionfs@...r.kernel.org, linux-mtd@...ts.infradead.org,
 linux-xfs@...r.kernel.org, linux-nfs@...r.kernel.org
Subject: Re: [PATCH 03/11] fs: exit early in generic_update_time when there is
 no work

On 12/22/25 16:37, Christoph Hellwig wrote:
> Exit early if no attributes are to be updated, to avoid a spurious call
> to __mark_inode_dirty which can turn into a fairly expensive no-op due to
> the extra checks and locking.
>
> Signed-off-by: Christoph Hellwig<hch@....de>
> Reviewed-by: Jan Kara<jack@...e.cz>
> Reviewed-by: Jeff Layton<jlayton@...nel.org>


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck