linux-kernel - Re: [PATCH 05/11] fs: return I_DIRTY_* and allow error returns from inode_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2d34cef-c0f4-4f27-91a0-439f85ed26b5@gmail.com>
Date: Mon, 22 Dec 2025 21:36:08 -0800
From: Chaitanya Kulkarni <ckulkarnilinux@...il.com>
To: Christoph Hellwig <hch@....de>, Christian Brauner <brauner@...nel.org>
Cc: Al Viro <viro@...iv.linux.org.uk>, David Sterba <dsterba@...e.com>,
 Jan Kara <jack@...e.cz>, Mike Marshall <hubcap@...ibond.com>,
 Martin Brandenburg <martin@...ibond.com>, Carlos Maiolino <cem@...nel.org>,
 Stefan Roesch <shr@...com>, Jeff Layton <jlayton@...nel.org>,
 linux-kernel@...r.kernel.org, linux-btrfs@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, gfs2@...ts.linux.dev,
 io-uring@...r.kernel.org, devel@...ts.orangefs.org,
 linux-unionfs@...r.kernel.org, linux-mtd@...ts.infradead.org,
 linux-xfs@...r.kernel.org, linux-nfs@...r.kernel.org
Subject: Re: [PATCH 05/11] fs: return I_DIRTY_* and allow error returns from
 inode_update_timestamps

On 12/22/25 16:37, Christoph Hellwig wrote:
> Change the inode_update_timestamps calling convention, so that instead
> of returning the updated flags that are only needed to calculate the
> I_DIRTY_* flags, return the I_DIRTY_* flags diretly in an argument, and
> reserve the return value to return an error code, which will be needed to
> support non-blocking timestamp updates.
>
> Signed-off-by: Christoph Hellwig<hch@....de>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck