linux-kernel - Re: [PATCH] pci: controller: tegra194: remove dependency on Tegra194 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xh2att7wpqowricyifxmoaijbhtrtoht25pomu4voosfctf36e@4p27y7rezz22>
Date: Tue, 23 Dec 2025 12:15:47 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Francesco Lavra <flavra@...libre.com>, thierry.reding@...il.com, 
	jonathanh@...dia.com
Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kwilczynski@...nel.org>, Rob Herring <robh@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Mayank Rana <mayank.rana@....qualcomm.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Shradha Todi <shradha.t@...sung.com>, 
	Thippeswamy Havalige <thippeswamy.havalige@....com>, Inochi Amaoto <inochiama@...il.com>, 
	Vidya Sagar <vidyas@...dia.com>, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: controller: tegra194: remove dependency on Tegra194
 SoC

On Wed, Nov 26, 2025 at 11:25:30AM +0100, Francesco Lavra wrote:

+ Tegra maintainers

> This driver runs (for both host and endpoint operation) also on other Tegra
> SoCs (e.g. Tegra234).
> Replace the Kconfig dependency on ARCH_TEGRA_194_SOC with a more generic
> dependency on ARCH_TEGRA; in addition, amend the Kconfig help text to
> reflect the fact that this driver is no longer exclusive to Tegra194.
> 

I vaguely remember asking about this a while back during some other patch review
and I don't remember what we concluded.

Thierry, Jon, thoughts?

- Mani

> Fixes: a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
> Signed-off-by: Francesco Lavra <flavra@...libre.com>
> ---
>  drivers/pci/controller/dwc/Kconfig | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index ff6b6d9e18ec..1123752e43ef 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -227,33 +227,33 @@ config PCIE_TEGRA194
>  
>  config PCIE_TEGRA194_HOST
>  	tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)"
> -	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
> +	depends on ARCH_TEGRA || COMPILE_TEST
>  	depends on PCI_MSI
>  	select PCIE_DW_HOST
>  	select PHY_TEGRA194_P2U
>  	select PCIE_TEGRA194
>  	help
> -	  Enables support for the PCIe controller in the NVIDIA Tegra194 SoC to
> -	  work in host mode. There are two instances of PCIe controllers in
> -	  Tegra194. This controller can work either as EP or RC. In order to
> -	  enable host-specific features PCIE_TEGRA194_HOST must be selected and
> -	  in order to enable device-specific features PCIE_TEGRA194_EP must be
> -	  selected. This uses the DesignWare core.
> +	  Enables support for the PCIe controller in the NVIDIA Tegra194 and
> +	  later SoCs to work in host mode. This controller can work either as
> +	  EP or RC. In order to enable host-specific features
> +	  PCIE_TEGRA194_HOST must be selected and in order to enable
> +	  device-specific features PCIE_TEGRA194_EP must be selected. This uses
> +	  the DesignWare core.
>  
>  config PCIE_TEGRA194_EP
>  	tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)"
> -	depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
> +	depends on ARCH_TEGRA || COMPILE_TEST
>  	depends on PCI_ENDPOINT
>  	select PCIE_DW_EP
>  	select PHY_TEGRA194_P2U
>  	select PCIE_TEGRA194
>  	help
> -	  Enables support for the PCIe controller in the NVIDIA Tegra194 SoC to
> -	  work in endpoint mode. There are two instances of PCIe controllers in
> -	  Tegra194. This controller can work either as EP or RC. In order to
> -	  enable host-specific features PCIE_TEGRA194_HOST must be selected and
> -	  in order to enable device-specific features PCIE_TEGRA194_EP must be
> -	  selected. This uses the DesignWare core.
> +	  Enables support for the PCIe controller in the NVIDIA Tegra194 and
> +	  later SoCs to work in endpoint mode. This controller can work either
> +	  as EP or RC. In order to enable host-specific features
> +	  PCIE_TEGRA194_HOST must be selected and in order to enable
> +	  device-specific features PCIE_TEGRA194_EP must be selected. This uses
> +	  the DesignWare core.
>  
>  config PCIE_DW_PLAT
>  	bool
> -- 
> 2.39.5
> 

-- 
மணிவண்ணன் சதாசிவம்