linux-kernel - Re: [PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9e7c86b-1a08-4ea4-bf41-75d406a13923@redhat.com>
Date: Tue, 23 Dec 2025 08:08:30 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: "illusion.wang" <illusion.wang@...ula-matrix.com>,
 dimon.zhao@...ula-matrix.com, alvin.wang@...ula-matrix.com,
 sam.chen@...ula-matrix.com, netdev@...r.kernel.org
Cc: open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs

On 12/23/25 4:50 AM, illusion.wang wrote:
> The patch series add the nbl driver, which will support the nebula-matrix 18100 and 18110 series 
> of network cards.
> This submission is the first phase. which includes the PF-based and VF-based Ethernet transmit 
> and receive functionality. Once this is merged. will submit addition patches to implement support
> for other features. such as ethtool support, debugfs support and etc.
> Our Driver architecture  supports Kernel Mode and Coexistence Mode(kernel and dpdk)

Not a real review, but this series has several basic issues:

- each patch should compile and build without warnings on all arches
- don't use inline in c code
- avoid using 'module_params'
- the preferred line width is still 80 chars
- strip changed-id from the commit message
- respect the reverse christmas tree order for variable declaration
- commit messages lines should be wrapped at 72 chars

Note that you can clone the NIPA repository:

https://github.com/linux-netdev/nipa/

and use the ingest_mdir.py script to validate most of the above check
before submission (otherwise you should do that manually).

However...

## Form letter - net-next-closed

The net-next tree is closed for new drivers, features, code refactoring
and optimizations due to the merge window and the winter break. We are
currently accepting bug fixes only.

Please repost when net-next reopens after Jan 2nd.

RFC patches sent for review only are obviously welcome at any time.