linux-kernel - Re: [PATCH v1 11/23] net: cadence: macb: Discard pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbd3cd9d-3a81-4f7d-9220-02d9df03d78a@microchip.com>
Date: Tue, 23 Dec 2025 09:48:27 +0100
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>, Linux PM
	<linux-pm@...r.kernel.org>
CC: LKML <linux-kernel@...r.kernel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
	Brian Norris <briannorris@...omium.org>, Claudiu Beznea
	<claudiu.beznea@...on.dev>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH v1 11/23] net: cadence: macb: Discard pm_runtime_put()
 return value

On 22/12/2025 at 21:14, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Passing pm_runtime_put() return value to the callers is not particularly
> useful.
> 
> Returning an error code from pm_runtime_put() merely means that it has
> not queued up a work item to check whether or not the device can be
> suspended and there are many perfectly valid situations in which that
> can happen, like after writing "on" to the devices' runtime PM "control"
> attribute in sysfs for one example.  It also happens when the kernel is
> configured with CONFIG_PM unset.
> 
> Accordingly, update at91ether_close() to simply discard the return
> value of pm_runtime_put() and always return success to the caller.
> 
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
> 
> This patch is part of a series, but it doesn't depend on anything else
> in that series.  The last patch in the series depends on it.
> 
> It can be applied by itself and if you decide to do so, please let me
> know.
> 
> Otherwise, an ACK or equivalent will be appreciated, but also the lack
> of specific criticism will be eventually regarded as consent.

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
Ok to take whichever route you choose, with a preference in staying with 
the other patches of the batch.

Thanks, regards,
   Nicolas

> ---
>   drivers/net/ethernet/cadence/macb_main.c |    4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4837,7 +4837,9 @@ static int at91ether_close(struct net_de
> 
>          at91ether_stop(lp);
> 
> -       return pm_runtime_put(&lp->pdev->dev);
> +       pm_runtime_put(&lp->pdev->dev);
> +
> +       return 0;
>   }
> 
>   /* Transmit packet */
> 
> 
>