linux-kernel - Re: [PATCH] ALSA: ac97: fix a double free in snd_ac97_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87qzslilcr.wl-tiwai@suse.de>
Date: Tue, 23 Dec 2025 10:44:04 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	robert.jarzmik@...e.fr,
	broonie@...nel.org,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] ALSA: ac97: fix a double free in snd_ac97_controller_register()

On Fri, 19 Dec 2025 17:28:45 +0100,
Haoxiang Li wrote:
> 
> If ac97_add_adapter() fails, put_device() is the correct way to drop
> the device reference. kfree() is not required.
> Add kfree() if idr_alloc() fails and in ac97_adapter_release() to do
> the cleanup.
> 
> Found by code review.
> 
> Fixes: 74426fbff66e ("ALSA: ac97: add an ac97 bus")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>

Thanks, applied now.


Takashi