linux-kernel - Re: [PATCH] ALSA: hda/tas2781: properly initialize speaker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o6npil17.wl-tiwai@suse.de>
Date: Tue, 23 Dec 2025 10:51:00 +0100
From: Takashi Iwai <tiwai@...e.de>
To: August Wikerfors <git@...ustwikerfors.se>
Cc: Shenghao Ding <shenghao-ding@...com>,
	Kevin Lu <kevin-lu@...com>,
	Baojun Xu <baojun.xu@...com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi
 Iwai <tiwai@...e.com>,
	Antheas Kapenekakis <lkml@...heas.dev>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/tas2781: properly initialize speaker_id for TAS2563

On Mon, 22 Dec 2025 20:47:04 +0100,
August Wikerfors wrote:
> 
> After speaker id retrieval was refactored to happen in tas2781_read_acpi,
> devices that do not use a speaker id need a negative speaker_id value
> instead of NULL, but no initialization was added to the TAS2563 code path.
> This causes the driver to attempt to load a non-existent firmware file name
> with a speaker id of 0 ("TAS2XXX38700.bin") instead of the correct file
> name without a speaker id ("TAS2XXX3870.bin"), resulting in low volume and
> these dmesg errors:
> 
>     tas2781-hda i2c-INT8866:00: Direct firmware load for TAS2XXX38700.bin failed with error -2
>     tas2781-hda i2c-INT8866:00: tasdevice_dsp_parser: load TAS2XXX38700.bin error
>     tas2781-hda i2c-INT8866:00: dspfw load TAS2XXX38700.bin error
>     [...]
>     tas2781-hda i2c-INT8866:00: tasdevice_prmg_load: Firmware is NULL
> 
> Fix this by setting speaker_id to -1 as is done for other models.
> 
> Fixes: 945865a0ddf3 ("ALSA: hda/tas2781: fix speaker id retrieval for multiple probes")
> Cc: stable@...r.kernel.org
> Signed-off-by: August Wikerfors <git@...ustwikerfors.se>

Applied now.  Thanks.


Takashi