linux-kernel - Re: [PATCH v7 3/9] software node: allow referencing firmware nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DF5J7H0BSBTK.362ZAJTRBK6U1@kernel.org>
Date: Tue, 23 Dec 2025 11:41:52 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Jiawen Wu" <jiawenwu@...stnetic.com>
Cc: "'Bartosz Golaszewski'" <brgl@...nel.org>, "'Bartosz Golaszewski'"
 <bartosz.golaszewski@...aro.org>, <andriy.shevchenko@...ux.intel.com>,
 <andy@...nel.org>, <broonie@...nel.org>, <ckeepax@...nsource.cirrus.com>,
 <david.rhodes@...rus.com>, <djrscally@...il.com>,
 <gregkh@...uxfoundation.org>, <heikki.krogerus@...ux.intel.com>,
 <krzk@...nel.org>, <linus.walleij@...aro.org>,
 <linux-acpi@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-sound@...r.kernel.org>,
 <linux-spi@...r.kernel.org>, <mstrozek@...nsource.cirrus.com>,
 <p.zabel@...gutronix.de>, <patches@...nsource.cirrus.com>,
 <rafael@...nel.org>, <rf@...nsource.cirrus.com>,
 <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH v7 3/9] software node: allow referencing firmware nodes

On Tue Dec 23, 2025 at 10:48 AM CET, Jiawen Wu wrote:
> On Tue, Dec 23, 2025 5:37 PM, Bartosz Golaszewski wrote:
>> On Tue, Dec 23, 2025 at 9:44 AM Jiawen Wu <jiawenwu@...stnetic.com> wrote:
>> > And I temporarily added this line to fix it:
>> >
>> > diff --git a/include/linux/property.h b/include/linux/property.h
>> > index 272bfbdea7bf..e30ef23a9af3 100644
>> > --- a/include/linux/property.h
>> > +++ b/include/linux/property.h
>> > @@ -371,6 +371,7 @@ struct software_node_ref_args {
>> >  (const struct software_node_ref_args) {                                \
>> >         .swnode = _Generic(_ref_,                               \
>> >                            const struct software_node *: _ref_, \
>> > +                          struct software_node *: _ref_,       \
>> >                            default: NULL),                      \
>> >         .fwnode = _Generic(_ref_,                               \
>> >                            struct fwnode_handle *: _ref_,       \
>> >
>> 
>> Ah I see, we'd assign struct software_node * to const struct
>> software_node * and it used to work but with _Generic() we need the
>> exact type. I agree with this approach, do you want to send a proper
>> patch?
>
> It might be more appropriate for you to send the patch, and could also
> check if there are any other missed details, like for fwnode...
> I'm not very proficient in this field. :)

There is already [1], which I queued up in the driver-core tree to send as fix
for -rc3.

[1] https://lore.kernel.org/lkml/20251219083638.2454138-1-sakari.ailus@linux.intel.com/