[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <DF57IWUPXAHM.27OHGD93IW5W@kernel.org>
Date: Tue, 23 Dec 2025 02:32:36 +0100
From: "Benno Lossin" <lossin@...nel.org>
To: "Tamir Duberstein" <tamird@...il.com>, "Benno Lossin"
<benno.lossin@...ton.me>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
<alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
<gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
"Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
"Danilo Krummrich" <dakr@...nel.org>, <linux-kernel@...r.kernel.org>,
<rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH] rust: pin_init_internal: fix rust-analyzer `mod quote`
On Mon Dec 22, 2025 at 1:43 PM CET, Tamir Duberstein wrote:
> On Thu, Mar 20, 2025 at 3:15 PM Tamir Duberstein <tamird@...il.com> wrote:
>>
>> On Thu, Mar 20, 2025 at 10:10 AM Benno Lossin <benno.lossin@...ton.me> wrote:
>> >
>> > On Thu Mar 20, 2025 at 2:31 PM CET, Tamir Duberstein wrote:
>> > > On Thu, Mar 20, 2025 at 8:16 AM Benno Lossin <benno.lossin@...ton.me> wrote:
>> > >> I'd rather not have this change, since this will introduce a dangling
>> > >> symlink upstream [1].
>> > >>
>> > >> [1]: https://github.com/rust-for-Linux/pin-init
>> > >
>> > > I agree it's aesthetically displeasing. I'm not aware of any
>> > > alternative that fixes the development workflow of this crate in the
>> > > kernel.
>> >
>> > I don't think it's too bad, and this code is going away soon-ish
>> > anyways.
>>
>> What would Andreas say? :)
>>
>> I don't think the going away soon argument is relevant in this case -
>> the same applies to the dangling symlink.
>
> 9 months later, this code is still here. What would make it go away?
The pin-init `syn` changes will land this cycle, which removes this
code.
Cheers,
Benno
Powered by blists - more mailing lists