linux-kernel - Re: [PATCH] crypto: hisilicon/sgl - fix inconsistent map/unmap direction issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7569c3cd-92ea-81c1-b57e-cebcacee66e7@huawei.com>
Date: Tue, 23 Dec 2025 20:37:01 +0800
From: Zenghui Yu <yuzenghui@...wei.com>
To: Chenghai Huang <huangchenghai2@...wei.com>
CC: <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
	<linux-kernel@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
	<fanghao11@...wei.com>, <liulongfang@...wei.com>, <qianweili@...wei.com>
Subject: Re: [PATCH] crypto: hisilicon/sgl - fix inconsistent map/unmap
 direction issue

On 2025/12/19 11:36, Chenghai Huang wrote:
> Ensure that the direction for dma_map_sg and dma_unmap_sg is
> consistent.
> 
> Fixes: 2566de3e06a3 ("crypto: hisilicon - Use fine grained DMA mapping direction")
> Signed-off-by: Chenghai Huang <huangchenghai2@...wei.com>
> ---
>  drivers/crypto/hisilicon/sgl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/hisilicon/sgl.c b/drivers/crypto/hisilicon/sgl.c
> index 24c7b6ab285b..d41b34405c21 100644
> --- a/drivers/crypto/hisilicon/sgl.c
> +++ b/drivers/crypto/hisilicon/sgl.c
> @@ -260,7 +260,7 @@ hisi_acc_sg_buf_map_to_hw_sgl(struct device *dev, struct scatterlist *sgl,
>  	return curr_hw_sgl;
>  
>  err_unmap:
> -	dma_unmap_sg(dev, sgl, sg_n, DMA_BIDIRECTIONAL);
> +	dma_unmap_sg(dev, sgl, sg_n, dir);
>  
>  	return ERR_PTR(ret);
>  }

Reviewed-by: Zenghui Yu <yuzenghui@...wei.com>

Thanks for fixing it!

Zenghui