linux-kernel - Re: [PATCH v3 1/2] dt-bindings: hwmon: add STEF48H28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251223-hissing-wonderful-sawfly-1b41ce@quoll>
Date: Tue, 23 Dec 2025 13:58:19 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charles Hsu <hsu.yungteng@...il.com>
Cc: Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, Jonathan Corbet <corbet@....net>, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: add STEF48H28

On Tue, Dec 23, 2025 at 09:48:31AM +0800, Charles Hsu wrote:
> Add device tree bindings for the hot-swap controller STEF48H28.
> 
> Signed-off-by: Charles Hsu <hsu.yungteng@...il.com>
> ---
>  .../bindings/hwmon/pmbus/st,stef48h28.yaml    | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> 

I do not understand what happened here and nothing is explained WHY in
the cover letter.

You did not respond to any comments

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> new file mode 100644
> index 000000000000..e4711c4ef38a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pmbus/st,stef48h28.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon XDP730 hot-swap controller with PMBus interface
> +
> +maintainers:
> +  - Charles Hsu <hsu.yungteng@...il.com>
> +
> +description: |
> +  The STEF48H28 is an advanced 30A integrated electronic fuse for
> +  the 9-80V DC power lines.
> +
> +  Datasheet:
> +    https://www.infineon.com/assets/row/public/documents/24/49/infineon-xdp730-001-datasheet-en.pdf
> +
> +allOf:
> +  - $ref: /schemas/regulator/regulator.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - st,stef48h28
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        stef48h28@11 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

> +            compatible = "st,stef48h28";
> +            reg = <0x11>;

Incomplete. Where are all other regulator properties (you claim this is
regulator), suplies, etc.

Best regards,
Krzysztof