linux-kernel - Re: [PATCH v3 3/5] dt-bindings: remoteproc: qcom,pas: Document pas for SoCCP on Kaanapali and Glymur platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251223-furry-mighty-agouti-a222f7@quoll>
Date: Tue, 23 Dec 2025 14:29:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jingyi Wang <jingyi.wang@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Mathieu Poirier <mathieu.poirier@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Manivannan Sadhasivam <mani@...nel.org>, aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com, 
	trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com, linux-arm-msm@...r.kernel.org, 
	linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Sibi Sankar <sibi.sankar@....qualcomm.com>
Subject: Re: [PATCH v3 3/5] dt-bindings: remoteproc: qcom,pas: Document pas
 for SoCCP on Kaanapali and Glymur platforms

On Tue, Dec 23, 2025 at 01:13:49AM -0800, Jingyi Wang wrote:
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
> index 63a82e7a8bf8..149e993282bb 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
> @@ -33,16 +33,22 @@ properties:
>        - description: Handover interrupt
>        - description: Stop acknowledge interrupt
>        - description: Shutdown acknowledge interrupt
> +      - description: Pong interrupt
> +      - description: Wake acknowledge interrupt
>  
>    interrupt-names:
>      minItems: 5
> +    maxItems: 7
>      items:
> -      - const: wdog
> -      - const: fatal
> -      - const: ready
> -      - const: handover
> -      - const: stop-ack
> -      - const: shutdown-ack
> +      enum:

No, no. Stop doing random changes. NAK

Now you remove strict order (see writing bindings) and claim every
device like SM8550 ADSP PAS has any order.

And it is now de-synced with interrupts. Read writing bindings - this is
clearly described there at line 90!

You can only grow existing list.



> +        - wdog
> +        - fatal
> +        - ready
> +        - handover
> +        - stop-ack
> +        - shutdown-ack
> +        - pong
> +        - wake-ack
>  
>    power-domains:
>      minItems: 1
> @@ -55,13 +61,21 @@ properties:
>    qcom,smem-states:
>      $ref: /schemas/types.yaml#/definitions/phandle-array
>      description: States used by the AP to signal the Hexagon core
> +    minItems: 1
>      items:
> -      - description: Stop the modem
> +      - description: Stop the remoteproc
> +      - description: Wake up the remoteproc
> +      - description: Make the remoteproc sleep
> +      - description: Ping the remoteproc

So every device like SM8550 PAS has now four smem states... without any
explanation. Read writing bindings - what does it say?

"... and define constraints specific to the device."

"DO define properties in terms of constraints. How many entries? What are
 possible values? What is the order? All these constraints represent the ABI
  as well."

It is your homework to read the docs. Not mine.

If you want to change common list you must define strict constraints for
EVERY user.

Best regards,
Krzysztof