linux-kernel - Re: [PATCH v2 4/6] dmaengine: sh: rz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXDhi9KqE5hS=z_UqWQ8Hzhy82NaqBMOm7c2q15=M=SBA@mail.gmail.com>
Date: Tue, 23 Dec 2025 14:50:37 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>
Cc: Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Magnus Damm <magnus.damm@...il.com>, Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, Johan Hovold <johan@...nel.org>, 
	Biju Das <biju.das.jz@...renesas.com>, dmaengine@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2 4/6] dmaengine: sh: rz_dmac: add RZ/{T2H,N2H} support

Hi Cosmin,

CC tglx

On Mon, 1 Dec 2025 at 13:50, Cosmin Tanislav
<cosmin-gabriel.tanislav.xa@...esas.com> wrote:
> The Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs use a
> completely different ICU unit compared to RZ/V2H, which requires a
> separate implementation.
>
> Add support for them.
>
> RZ/N2H will use RZ/T2H as a fallback.
>
> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>

Thanks for your patch!

> --- a/drivers/dma/sh/rz-dmac.c
> +++ b/drivers/dma/sh/rz-dmac.c
> @@ -15,6 +15,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/iopoll.h>
>  #include <linux/irqchip/irq-renesas-rzv2h.h>
> +#include <linux/irqchip/irq-renesas-rzt2h.h>

As this has a hard dependency on commit 13e7b3305b647cf5 ("irqchip: Add
RZ/{T2H,N2H} Interrupt Controller (ICU) driver") in irqchip/irq/drivers
(next-20251217 and later), Vinod cannot apply this patch without
merging that dependency first.

>  #include <linux/list.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> @@ -1073,12 +1074,18 @@ static const struct rz_dmac_info rz_dmac_v2h_info = {
>         .dma_req_no_default = RZV2H_ICU_DMAC_REQ_NO_DEFAULT,
>  };
>
> +static const struct rz_dmac_info rz_dmac_t2h_info = {
> +       .register_dma_req = rzt2h_icu_register_dma_req,
> +       .dma_req_no_default = RZT2H_ICU_DMAC_REQ_NO_DEFAULT,
> +};
> +
>  static const struct rz_dmac_info rz_dmac_common_info = {
>         .dma_req_no_default = 0,
>  };
>
>  static const struct of_device_id of_rz_dmac_match[] = {
>         { .compatible = "renesas,r9a09g057-dmac", .data = &rz_dmac_v2h_info },
> +       { .compatible = "renesas,r9a09g077-dmac", .data = &rz_dmac_t2h_info },
>         { .compatible = "renesas,rz-dmac", .data = &rz_dmac_common_info },
>         { /* Sentinel */ }
>  };

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds