linux-kernel - Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb775051-8635-4e2d-a1f9-46d6f0e6bc15@kernel.org>
Date: Tue, 23 Dec 2025 15:16:41 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vinod Koul <vkoul@...nel.org>,
 Krishna Kurapati <krishna.kurapati@....qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Abel Vesa <abelvesa@...nel.org>,
 Pengyu Luo <mitltlatltl@...il.com>, Johan Hovold <johan+linaro@...nel.org>,
 Luca Weiss <luca.weiss@...rphone.com>, linux-arm-msm@...r.kernel.org,
 linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add
 squelch param update

On 23/12/2025 15:11, Vinod Koul wrote:
> On 19-12-25, 23:01, Krishna Kurapati wrote:
>> Add squelch detect parameter update for synopsys eusb2 repeater. The
>> values (indicated in basis-points) depict a percentage change with
>> respect to the nominal value.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
>> ---
>>  .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
>> index 5bf0d6c9c025..f2afcf0e986a 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
>> @@ -59,6 +59,14 @@ properties:
>>      minimum: 0
>>      maximum: 7
>>  
>> +  qcom,squelch-detector-bp:
>> +    description:
>> +      This adjusts the voltage level for the threshold used to detect valid
>> +      high-speed data.
>> +    minimum: -6000
> 
> 6000Volts, mV, can you please document the units?


Code is correct, the '-bp' is the unit here. Unless the suffix was
chosen incorrectly?


Best regards,
Krzysztof