linux-kernel - [PATCH] scsi: esas2r: fix a resource leak in esas2r

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251223141547.1506688-1-lihaoxiang@isrc.iscas.ac.cn>
Date: Tue, 23 Dec 2025 22:15:47 +0800
From: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
To: James.Bottomley@...senPartnership.com,
	martin.petersen@...cle.com,
	JBottomley@...allels.com
Cc: linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>,
	stable@...r.kernel.org
Subject: [PATCH] scsi: esas2r: fix a resource leak in esas2r_resume()

Add esas2r_unmap_regions() to release the resources
allocated by esas2r_map_regions() in some error paths.

Found by code review and compiled on ubuntu 20.04.

Fixes: 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver")
Cc: stable@...r.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
---
 drivers/scsi/esas2r/esas2r_init.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c
index 04a07fe57be2..114239373f28 100644
--- a/drivers/scsi/esas2r/esas2r_init.c
+++ b/drivers/scsi/esas2r/esas2r_init.c
@@ -684,7 +684,7 @@ static int __maybe_unused esas2r_resume(struct device *dev)
 	if (!esas2r_power_up(a, true)) {
 		esas2r_debug("yikes, esas2r_power_up failed");
 		rez = -ENOMEM;
-		goto error_exit;
+		goto error_unmap;
 	}
 
 	esas2r_claim_interrupts(a);
@@ -700,9 +700,11 @@ static int __maybe_unused esas2r_resume(struct device *dev)
 		esas2r_debug("yikes, unable to claim IRQ");
 		esas2r_log(ESAS2R_LOG_CRIT, "could not re-claim IRQ!");
 		rez = -ENOMEM;
-		goto error_exit;
+		goto error_unmap;
 	}
 
+error_unmap:
+	esas2r_unmap_regions(a);
 error_exit:
 	esas2r_log_dev(ESAS2R_LOG_CRIT, dev, "esas2r_resume(): %d",
 		       rez);
-- 
2.25.1