linux-kernel - Re: [PATCH] crypto: hisilicon/qm - fix incorrect judgment in qm_get_complete_eqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cde67fee-c90a-437e-a8be-a27865f8a2ed@huawei.com>
Date: Tue, 23 Dec 2025 09:46:31 +0800
From: huangchenghai <huangchenghai2@...wei.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
	<linux-crypto@...r.kernel.org>, <liulongfang@...wei.com>,
	<qianweili@...wei.com>, <linwenkai6@...ilicon.com>, <wangzhou1@...ilicon.com>
Subject: Re: [PATCH] crypto: hisilicon/qm - fix incorrect judgment in
 qm_get_complete_eqe_num()


在 2025/12/22 12:22, Herbert Xu 写道:
> On Mon, Dec 22, 2025 at 11:00:28AM +0800, huangchenghai wrote:
>> 在 2025/12/19 14:56, Herbert Xu 写道:
>>> On Thu, Nov 20, 2025 at 09:21:24PM +0800, Chenghai Huang wrote:
>>>> In qm_get_complete_eqe_num(), the function entry has already
>>>> checked whether the interrupt is valid, so the interrupt event
>>>> can be processed directly. Currently, the interrupt valid bit is
>>>> being checked again redundantly, and no interrupt processing is
>>>> performed. Therefore, the loop condition should be modified to
>>>> directly process the interrupt event, and use do while instead of
>>>> the current while loop, because the condition is always satisfied
>>>> on the first iteration.
>>>>
>>>> Fixes: f5a332980a68 ("crypto: hisilicon/qm - add the save operation of eqe and aeqe")
>>>> Signed-off-by: Chenghai Huang <huangchenghai2@...wei.com>
>>>> ---
>>>>    drivers/crypto/hisilicon/qm.c | 9 ++++-----
>>>>    1 file changed, 4 insertions(+), 5 deletions(-)
>>> Patch applied.  Thanks.
>> This patch addresses an issue specific to version 6.19.
>>
>> Could you please help including this patch in the 6.19?
> The patch looked like a clean-up rather than a bug fix.
>
> Could you please explain how it makes any difference at all?
>
> Thanks,

Commit f5a332980a68 ("crypto: hisilicon/qm - add the save operation of 
eqe and aeqe")

introduced an incorrect condition check, which prevents

the while loop from being entered to handle interrupt tasks.

Normally, the code should enter the while loop to process these tasks.


Chenghai