linux-kernel - Re: [PATCH 1/2] crypto: hisilicon/trng - use DEFINE_MUTEX() and LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUtUqF7eHUY6Pw76@gondor.apana.org.au>
Date: Wed, 24 Dec 2025 10:49:12 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: huangchenghai <huangchenghai2@...wei.com>
Cc: davem@...emloft.net, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, fanghao11@...wei.com,
	liulongfang@...wei.com, qianweili@...wei.com,
	linwenkai6@...ilicon.com, wangzhou1@...ilicon.com
Subject: Re: [PATCH 1/2] crypto: hisilicon/trng - use DEFINE_MUTEX() and
 LIST_HEAD()

On Mon, Dec 22, 2025 at 02:10:32PM +0800, huangchenghai wrote:
>
> I tried to solve this scenario by adding CRYPTO_ALG_DUP_FIRST:

You're right that it's broken.  Either the duplication needs to be
moved to the driver, or the unregistration needs to find the
duplicated algorithm.

Let me fix this up first.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt