linux-kernel - Re: [PATCH v3 2/3] of: factor arguments passed to of_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202512241116.41ldSEgi-lkp@intel.com>
Date: Wed, 24 Dec 2025 11:37:22 +0800
From: kernel test robot <lkp@...el.com>
To: Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>,
	robin.murphy@....com, will@...nel.org, joro@...tes.org,
	robh@...nel.org, dmitry.baryshkov@....qualcomm.com,
	konrad.dybcio@....qualcomm.com, bjorn.andersson@....qualcomm.com,
	bod@...nel.org, conor+dt@...nel.org, krzk+dt@...nel.org,
	saravanak@...gle.com, prakash.gupta@....qualcomm.com,
	vikash.garodia@....qualcomm.com
Cc: oe-kbuild-all@...ts.linux.dev, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Charan Teja Kalla <charan.kalla@....qualcomm.com>,
	Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>
Subject: Re: [PATCH v3 2/3] of: factor arguments passed to of_map_id() into a
 struct

Hi Vijayanand,

kernel test robot noticed the following build warnings:

[auto build test WARNING on xen-tip/linux-next]
[cannot apply to robh/for-next pci/next pci/for-linus linus/master v6.19-rc2 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vijayanand-Jitta/of-Add-convenience-wrappers-for-of_map_id/20251222-053941
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
patch link:    https://lore.kernel.org/r/20251221213602.2413124-3-vijayanand.jitta%40oss.qualcomm.com
patch subject: [PATCH v3 2/3] of: factor arguments passed to of_map_id() into a struct
config: arc-allnoconfig (https://download.01.org/0day-ci/archive/20251224/202512241116.41ldSEgi-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251224/202512241116.41ldSEgi-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512241116.41ldSEgi-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/of/base.c: In function 'of_map_id':
>> drivers/of/base.c:2078:63: warning: the comparison will always evaluate as 'true' for the address of 'args' will never be NULL [-Waddress]
    2078 |         if (!np || !map_name || !arg || (!arg->map_args.np && !arg->map_args.args))
         |                                                               ^
   In file included from drivers/of/base.c:24:
   include/linux/of.h:74:18: note: 'args' declared here
      74 |         uint32_t args[MAX_PHANDLE_ARGS];
         |                  ^~~~
   drivers/of/base.c:2136:21: warning: the comparison will always evaluate as 'true' for the address of 'args' will never be NULL [-Waddress]
    2136 |                 if (arg->map_args.args)
         |                     ^~~
   include/linux/of.h:74:18: note: 'args' declared here
      74 |         uint32_t args[MAX_PHANDLE_ARGS];
         |                  ^~~~
   drivers/of/base.c:2149:13: warning: the comparison will always evaluate as 'true' for the address of 'args' will never be NULL [-Waddress]
    2149 |         if (arg->map_args.args)
         |             ^~~
   include/linux/of.h:74:18: note: 'args' declared here
      74 |         uint32_t args[MAX_PHANDLE_ARGS];
         |                  ^~~~


vim +2078 drivers/of/base.c

  2047	
  2048	/**
  2049	 * of_map_id - Translate an ID through a downstream mapping.
  2050	 * @np: root complex device node.
  2051	 * @id: device ID to map.
  2052	 * @map_name: property name of the map to use.
  2053	 * @map_mask_name: optional property name of the mask to use.
  2054	 * @arg: contains the optional params, wrapped in a struct of_phandle_args,
  2055	 *	which includes:
  2056	 *	np: pointer to the target device node
  2057	 *	args_count: number of arguments
  2058	 *	args[]: array to receive the translated ID(s).
  2059	 *
  2060	 * Given a device ID, look up the appropriate implementation-defined
  2061	 * platform ID and/or the target device which receives transactions on that
  2062	 * ID, as per the "iommu-map" and "msi-map" bindings. Either of @target or
  2063	 * @id_out may be NULL if only the other is required. If @target points to
  2064	 * a non-NULL device node pointer, only entries targeting that node will be
  2065	 * matched; if it points to a NULL value, it will receive the device node of
  2066	 * the first matching target phandle, with a reference held.
  2067	 *
  2068	 * Return: 0 on success or a standard error code on failure.
  2069	 */
  2070	int of_map_id(const struct device_node *np, u32 id,
  2071		       const char *map_name, const char *map_mask_name,
  2072		       struct of_map_id_arg *arg)
  2073	{
  2074		u32 map_mask, masked_id;
  2075		int map_len;
  2076		const __be32 *map = NULL;
  2077	
> 2078		if (!np || !map_name || !arg || (!arg->map_args.np && !arg->map_args.args))

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki