linux-kernel - Re: [PATCH 1/2] ecryptfs: Fix improper mknod pairing of start_creating()/end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxhnw1sa1xxii+2r69hFs02sagbQt6uLti5TxSnaHk_Kkg@mail.gmail.com>
Date: Wed, 24 Dec 2025 07:23:52 +0100
From: Amir Goldstein <amir73il@...il.com>
To: Tyler Hicks <code@...icks.com>
Cc: NeilBrown <neil@...wn.name>, Christian Brauner <brauner@...nel.org>, 
	Jeff Layton <jlayton@...nel.org>, ecryptfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ecryptfs: Fix improper mknod pairing of start_creating()/end_removing()

On Tue, Dec 23, 2025 at 9:42 PM Tyler Hicks <code@...icks.com> wrote:
>
> The ecryptfs_start_creating_dentry() function must be paired with the
> end_creating() function. Fix ecryptfs_mknod() so that end_creating() is
> properly called in the return path, instead of end_removing().
>
> Fixes: f046fbb4d81d ("ecryptfs: use new start_creating/start_removing APIs")
> Signed-off-by: Tyler Hicks <code@...icks.com>
> ---
>  fs/ecryptfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
> index 3978248247dc..e73d9de676a6 100644
> --- a/fs/ecryptfs/inode.c
> +++ b/fs/ecryptfs/inode.c
> @@ -584,7 +584,7 @@ ecryptfs_mknod(struct mnt_idmap *idmap, struct inode *dir,
>         fsstack_copy_attr_times(dir, lower_dir);
>         fsstack_copy_inode_size(dir, lower_dir);
>  out:
> -       end_removing(lower_dentry);
> +       end_creating(lower_dentry);
>         if (d_really_is_negative(dentry))
>                 d_drop(dentry);
>         return rc;
> --

Doh! Who's the dummy who reviewed this patch :-/

FWIW now

Reviewed-by: Amir Goldstein <amir73il@...il.com>

Thanks,
Amir.

> 2.43.0
>