linux-kernel - Re: [PATCH 1/1] serial: core: Fix serial device initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18a5d332-7ba3-47aa-bee9-1e5f5b724b80@oss.qualcomm.com>
Date: Wed, 24 Dec 2025 15:10:36 +0800
From: Jingyi Wang <jingyi.wang@....qualcomm.com>
To: Alexander Stein <alexander.stein@...tq-group.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        Cosmin Tanislav <demonsingur@...il.com>
Subject: Re: [PATCH 1/1] serial: core: Fix serial device initialization



On 12/19/2025 11:28 PM, Alexander Stein wrote:
> During restoring sysfs fwnode information the information of_node_reused
> was dropped. This was previously set by device_set_of_node_from_dev().
> Add it back manually
> 
> Fixes: 24ec03cc5512 ("serial: core: Restore sysfs fwnode information")
> Suggested-by: Cosmin Tanislav <demonsingur@...il.com>
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
>  drivers/tty/serial/serial_base_bus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/serial_base_bus.c b/drivers/tty/serial/serial_base_bus.c
> index 8e891984cdc0d..1e1ad28d83fcf 100644
> --- a/drivers/tty/serial/serial_base_bus.c
> +++ b/drivers/tty/serial/serial_base_bus.c
> @@ -74,6 +74,7 @@ static int serial_base_device_init(struct uart_port *port,
>  	dev->parent = parent_dev;
>  	dev->bus = &serial_base_bus_type;
>  	dev->release = release;
> +	dev->of_node_reused = true;
>  
>  	device_set_node(dev, fwnode_handle_get(dev_fwnode(parent_dev)));
>  

This can fix the broken serial on the Qualcomm Kaanapali device on the latest tag.

Thanks,
Jingyi