linux-kernel - Re: [PATCH] media: iris: Add missing platform data entries for SM8750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07b1a76f-02dd-4973-841d-9ea9e6fb4147@oss.qualcomm.com>
Date: Wed, 24 Dec 2025 14:27:15 +0530
From: Vikash Garodia <vikash.garodia@....qualcomm.com>
To: Dikshita Agarwal <dikshita.agarwal@....qualcomm.com>,
        Abhinav Kumar <abhinav.kumar@...ux.dev>,
        Bryan O'Donoghue <bod@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Hans Verkuil <hverkuil+cisco@...nel.org>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] media: iris: Add missing platform data entries for SM8750



On 12/18/2025 12:24 PM, Dikshita Agarwal wrote:
> Two platform-data fields for SM8750 were missed:
> 
>    - get_vpu_buffer_size = iris_vpu33_buf_size
>      Without this, the driver fails to allocate the required internal
>      buffers, leading to basic decode/encode failures during session
>      bring-up.
> 
>    - max_core_mbps = ((7680 * 4320) / 256) * 60
>      Without this capability exposed, capability checks are incomplete and
>      v4l2-compliance for encoder fails.
> 
> Fixes: a5925a2ce077 ("media: iris: add VPU33 specific encoding buffer calculation")
> Fixes: a6882431a138 ("media: iris: Add support for ENUM_FRAMESIZES/FRAMEINTERVALS for encoder")
> Cc: stable@...r.kernel.org
> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@....qualcomm.com>
> ---
>   drivers/media/platform/qcom/iris/iris_platform_gen2.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> index c1989240c248601c34b84f508f1b72d72f81260a..00d1d55463179429f2ae7554546dcbe4fb1431cc 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> @@ -915,6 +915,7 @@ const struct iris_platform_data sm8750_data = {
>   	.get_instance = iris_hfi_gen2_get_instance,
>   	.init_hfi_command_ops = iris_hfi_gen2_command_ops_init,
>   	.init_hfi_response_ops = iris_hfi_gen2_response_ops_init,
> +	.get_vpu_buffer_size = iris_vpu33_buf_size,
>   	.vpu_ops = &iris_vpu35_ops,
>   	.set_preset_registers = iris_set_sm8550_preset_registers,
>   	.icc_tbl = sm8550_icc_table,
> @@ -945,6 +946,7 @@ const struct iris_platform_data sm8750_data = {
>   	.num_vpp_pipe = 4,
>   	.max_session_count = 16,
>   	.max_core_mbpf = NUM_MBS_8K * 2,
> +	.max_core_mbps = ((7680 * 4320) / 256) * 60,
>   	.dec_input_config_params_default =
>   		sm8550_vdec_input_config_params_default,
>   	.dec_input_config_params_default_size =
> 

Reviewed-by: Vikash Garodia<vikash.garodia@....qualcomm.com