linux-kernel - Re: [PATCH v11 07/10] erofs: introduce the page cache share feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84328aa9-5b84-4433-83ce-7147c100f5d2@linux.alibaba.com>
Date: Wed, 24 Dec 2025 18:05:11 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Hongbo Li <lihongbo22@...wei.com>
Cc: linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, Chao Yu <chao@...nel.org>,
 Christian Brauner <brauner@...nel.org>, "Darrick J. Wong"
 <djwong@...nel.org>, Amir Goldstein <amir73il@...il.com>,
 Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v11 07/10] erofs: introduce the page cache share feature

On 2025/12/24 17:26, Hongbo Li wrote:
> 
> Hi, Xiang
> On 2025/12/24 16:09, Gao Xiang wrote:
>>

...

>>
>> why return `struct erofs_inode_fingerprint` instead of:
>>
>> int erofs_xattr_get_ishare_fp(struct erofs_inode_fingerprint *fp,
>>                    struct inode *inode, const char *domain_id)
>>
>> instead?
>>
> 
> How about declaring this as void erofs_xattr_fill_ishare_fp(struct erofs_inode_fingerprint *fp, struct inode *inode, const char *domain_id)? Because the return value seems useless.

I still perfer to return different values for this helper
even the final user doesn't use this.

Thanks,
Gao Xiang

> 
> Thanks,
> Hongbo