linux-kernel - Re: [PATCH v1 net-next 07/15] net/nebula-matrix: add vsi, queue, adminq resource definitions and implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebe0444d-28cd-4c19-bd35-1aa0971e8c41@lunn.ch>
Date: Wed, 24 Dec 2025 11:49:01 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "illusion.wang" <illusion.wang@...ula-matrix.com>
Cc: dimon.zhao@...ula-matrix.com, alvin.wang@...ula-matrix.com,
	sam.chen@...ula-matrix.com, netdev@...r.kernel.org,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 net-next 07/15] net/nebula-matrix: add vsi, queue,
 adminq resource definitions and implementation

> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/base/nbl_datapath.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0*/
> +/*
> + * Copyright (c) 2025 Nebula Matrix Limited.
> + * Author:
> + */
> +// Code generated by interstellar. DO NOT EDIT.
> +// Compatible with leonis RTL tag 0710

That patch is way too big, it is unlikely anybody will review it for
you.

One thing which will help is put all the machine generated headers in
a separate patch. Make sure the commit message makes it clear this is
machine generated. Human reviewers will then only take a quick look,
but mostly ignore it. That helps make the real code which needs human
review stand out.

       Andrew