linux-kernel - Re: [PATCH] bus: fsl-mc: fix an error handling in fsl_mc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251224105240.1588158-1-lihaoxiang@isrc.iscas.ac.cn>
Date: Wed, 24 Dec 2025 18:52:40 +0800
From: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
To: chleroy@...nel.org
Cc: dan.carpenter@...aro.org,
	ioana.ciornei@....com,
	lihaoxiang@...c.iscas.ac.cn,
	linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org,
	suhui@...china.com
Subject: Re: [PATCH] bus: fsl-mc: fix an error handling in fsl_mc_device_add()

On Wed, 24 Dec 2025 10:57:52 +0100, Christophe Leroy wrote:
> Ok, then this needs to be said in the commit message.

I will add it in the patch v2.

> By the way I'm a bit puzzled by the device_add() doc versus the 
> put_device(), because it looks like device_add() already calls 
> put_device() in its error path, see 
> https://elixir.bootlin.com/linux/v6.19-rc2/source/drivers/base/core.c#L3716

I think this is because device_add() increment the reference in the
beginning, see
https://elixir.bootlin.com/linux/v6.19-rc2/source/drivers/base/core.c#L3580
and if device_add() fails, another put_device() should be called to decrement
the reference which is obtained by device_initialize().

Thanks,
Haoxiang Li