linux-kernel - Re: [PATCH] perf jit: close agent in Agent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251224113918.1593967-1-lihaoxiang@isrc.iscas.ac.cn>
Date: Wed, 24 Dec 2025 19:39:18 +0800
From: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
To: james.clark@...aro.org
Cc: acme@...nel.org,
	adrian.hunter@...el.com,
	alexander.shishkin@...ux.intel.com,
	irogers@...gle.com,
	jolsa@...nel.org,
	lihaoxiang@...c.iscas.ac.cn,
	linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org,
	mark.rutland@....com,
	mingo@...hat.com,
	namhyung@...nel.org,
	peterz@...radead.org,
	yuzhuo@...gle.com
Subject: Re: [PATCH] perf jit: close agent in Agent_OnLoad()

On Wed, 24 Dec 2025 10:39:18 +0000, James Clark wrote:
> Does this actually do anything? jvmti_close() is already called in 
> Agent_OnUnload().

I think Agent_OnUnload() is not called if Agent_Onload() fails, so it
is necessary to release the resource.

> The commit message is lacking any details about how this was found or 
> what the effect is.

Sorry for that. I found it by a static analyzer prototype and comfirmed
by manual review. I think it leads to a resource leak.

If this is ok, I modify the changelog and resubmit it.

Thanks,
Haoxiang Li