linux-kernel - Re: [PATCH net-next] vsock/test: add a final full barrier after run all tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUvn7yVoSPG_FIiD@leonardi-redhat>
Date: Wed, 24 Dec 2025 14:18:17 +0100
From: Luigi Leonardi <leonardi@...hat.com>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: netdev@...r.kernel.org, virtualization@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] vsock/test: add a final full barrier after run
 all tests

On Tue, Dec 23, 2025 at 05:22:10PM +0100, Stefano Garzarella wrote:
>From: Stefano Garzarella <sgarzare@...hat.com>
>
>If the last test fails, the other side still completes correctly,
>which could lead to false positives.
>
>Let's add a final barrier that ensures that the last test has finished
>correctly on both sides, but also that the two sides agree on the
>number of tests to be performed.
>
>Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>
>---
> tools/testing/vsock/util.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
>index d843643ced6b..9430ef5b8bc3 100644
>--- a/tools/testing/vsock/util.c
>+++ b/tools/testing/vsock/util.c
>@@ -511,6 +511,18 @@ void run_tests(const struct test_case *test_cases,
>
> 		printf("ok\n");
> 	}
>+
>+	printf("All tests have been executed. Waiting other peer...");
>+	fflush(stdout);
>+
>+	/*
>+	 * Final full barrier, to ensure that all tests have been run and
>+	 * that even the last one has been successful on both sides.
>+	 */
>+	control_writeln("COMPLETED");
>+	control_expectln("COMPLETED");
>+
>+	printf("ok\n");
> }
>
> void list_tests(const struct test_case *test_cases)
>-- 
>2.52.0
>

LGTM!

Reviewed-by: Luigi Leonardi <leonardi@...hat.com>