linux-kernel - Re: [PATCH 0/2] Fix two regressions from start_creating()/start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUv9C5Z4Y996T8BT@yaupon>
Date: Wed, 24 Dec 2025 08:47:39 -0600
From: Tyler Hicks <code@...icks.com>
To: Amir Goldstein <amir73il@...il.com>
Cc: Christian Brauner <brauner@...nel.org>, NeilBrown <neil@...wn.name>,
	Jeff Layton <jlayton@...nel.org>, ecryptfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 0/2] Fix two regressions from
 start_creating()/start_removing() conversion

On 2025-12-24 07:31:59, Amir Goldstein wrote:
> On Tue, Dec 23, 2025 at 9:42 PM Tyler Hicks <code@...icks.com> wrote:
> >
> > When running the eCryptfs test suite on v6.19-rc2, I noticed BUG splats
> > from every test and that the umount utility was segfaulting when tearing
> > down after a test. Bisection led me to commit f046fbb4d81d ("ecryptfs:
> > use new start_creating/start_removing APIs").
> >
> > This patch series addresses that regression and also a mknod problem
> > spotted during code review.
> >
> 
> Ouch!
> 
> Christian,
> 
> In retrospect, it's a shame that patches get merged with zero test coverage
> and no ACK from the maintainer.

I wasn't able to be a very active maintainer over the last year. I think
Christian did the right thing here.

> OTOH, relying on ACKs from all fs maintainers will seriously impair
> the ability to make vfs wide changes like this one.

Exactly. The fringe filesystems shouldn't slow down the entire VFS.

> Feels like we need to find a better balance.
> 
> At least for ecryptfs, if we know that Tyler is at least testing rc1
> regularly (?) that's a comfort.

I will be more active going forward and now have an easy setup for
testing rc1's regularly.

Tyler

> 
> Thanks,
> Amir.