linux-kernel - Re: [PATCH v6 10/11] riscv: dts: add initial canmv-k230 and k230-evb dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUzjn3XHJTSl3vY9@duge-virtual-machine>
Date: Thu, 25 Dec 2025 15:11:27 +0800
From: Jiayu Du <jiayu.riscv@...c.iscas.ac.cn>
To: Yangyu Chen <cyy@...self.name>, linux-riscv@...ts.infradead.org
Cc: Conor Dooley <conor@...nel.org>, Damien Le Moal <dlemoal@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Guo Ren <guoren@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Philipp Zabel <p.zabel@...gutronix.de>, linux-gpio@...r.kernel.org,
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 10/11] riscv: dts: add initial canmv-k230 and k230-evb
 dts

On Sat, Mar 23, 2024 at 08:12:22PM +0800, Yangyu Chen wrote:
...
> diff --git a/arch/riscv/boot/dts/canaan/k230.dtsi b/arch/riscv/boot/dts/canaan/k230.dtsi
...
> +
> +	aliases {
> +		serial0 = &uart0;
> +	};

The aliases should be set in the board-level dts file,
so please consider removing the aliases.

...
> +
> +		plic: interrupt-controller@...000000 {
> +			compatible = "canaan,k230-plic" ,"thead,c900-plic";
Incorrect comma separation. It should be: "canaan,k230-plic", "thead,c900-plic";
> +			reg = <0xf 0x00000000 0x0 0x04000000>;
> +			interrupts-extended = <&cpu0_intc 11>, <&cpu0_intc 9>;
> +			interrupt-controller;
> +			#address-cells = <0>;
> +			#interrupt-cells = <2>;
...
> -- 
> 2.43.0
>