linux-kernel - Re: [PATCH 4/5] virt: add Bao I/O dispatcher driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251225-friendly-raptor-of-lightning-fbafc4@quoll>
Date: Thu, 25 Dec 2025 10:12:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: joaopeixoto@...x.tech
Cc: linux-kernel@...r.kernel.org, ajd@...ux.ibm.com, alex@...ti.fr, 
	aou@...s.berkeley.edu, bagasdotme@...il.com, catalin.marinas@....com, 
	conor+dt@...nel.org, corbet@....net, dan.j.williams@...el.com, 
	davidmcerdeira@...x.tech, devicetree@...r.kernel.org, dev@...l-k.io, 
	gregkh@...uxfoundation.org, haren@...ux.ibm.com, heiko@...ech.de, jose@...x.tech, 
	kever.yang@...k-chips.com, krzk+dt@...nel.org, linux-arm-kernel@...ts.infradead.org, 
	linux@...linux.org.uk, linux-doc@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	maddy@...ux.ibm.com, mani@...nel.org, nathan@...nel.org, neil.armstrong@...aro.org, 
	palmer@...belt.com, pjw@...nel.org, prabhakar.mahadev-lad.rj@...renesas.com, 
	robh@...nel.org, will@...nel.org
Subject: Re: [PATCH 4/5] virt: add Bao I/O dispatcher driver

On Wed, Dec 24, 2025 at 01:52:16PM +0000, joaopeixoto@...x.tech wrote:
> +static const struct of_device_id bao_io_dispatcher_driver_dt_ids[] = {
> +	{ .compatible = "bao,io-dispatcher" },
> +	{ /* sentinel */ }
> +};
> +
> +MODULE_DEVICE_TABLE(of, bao_io_dispatcher_driver_dt_ids);
> +
> +static struct platform_driver bao_io_dispatcher_driver = {
> +	.probe = bao_io_dispatcher_driver_register,
> +	.remove = bao_io_dispatcher_driver_unregister,
> +	.driver = {
> +		   .name = "bao-io-dispatcher",
> +		   .of_match_table =
> +		   of_match_ptr(bao_io_dispatcher_driver_dt_ids),

You have warnings here. Do extensive building of your code before
sending.

> +		   .owner = THIS_MODULE,

NAK

Don't send us 12-year-old vendor code. Tools already report this,
so you just did not run them...

Nothing here is evn formatted correctly...

Best regards,
Krzysztof