linux-kernel - Re: [PATCH 4/4] mips: bmips: dts: fix qspi register order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a31ece17-aac6-4369-b2ed-efd76e8961fe@kernel.org>
Date: Thu, 25 Dec 2025 13:35:20 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jonas Gorski <jonas.gorski@...il.com>,
 Kamal Dasu <kamal.dasu@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Rafał Miłecki <rafal@...ecki.pl>
Cc: Kamal Dasu <kdasu.kdev@...il.com>, linux-spi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mips@...r.kernel.org
Subject: Re: [PATCH 4/4] mips: bmips: dts: fix qspi register order

On 25/12/2025 11:25, Jonas Gorski wrote:
> Align the register order to the schema. Fixes warnings like:
> 
> arch/mips/boot/dts/brcm/bcm97435svmb.dtb: spi@...200 (brcm,spi-brcmstb-qspi): reg-names:0: 'cs_reg' is not one of ['hif_mspi', 'mspi']
> 	from schema $id: http://devicetree.org/schemas/spi/brcm,spi-bcm-qspi.yaml
> arch/mips/boot/dts/brcm/bcm97435svmb.dtb: spi@...200 (brcm,spi-brcmstb-qspi): reg-names:1: 'bspi' was expected
> 	from schema $id: http://devicetree.org/schemas/spi/brcm,spi-bcm-qspi.yaml
> arch/mips/boot/dts/brcm/bcm97435svmb.dtb: spi@...200 (brcm,spi-brcmstb-qspi): reg-names:2: 'bspi' is not one of ['intr_regs', 'intr_status_reg', 'cs_reg']
> 	from schema $id: http://devicetree.org/schemas/spi/brcm,spi-bcm-qspi.yaml

Trim redundant parts. You do not need to paste schema path every time.
Full path to DTB also is not really necessary, IMO.

> 
> Signed-off-by: Jonas Gorski <jonas.gorski@...il.com>
> ---
>  arch/mips/boot/dts/brcm/bcm7125.dtsi | 4 ++--
>  arch/mips/boot/dts/brcm/bcm7346.dtsi | 4 ++--
>  arch/mips/boot/dts/brcm/bcm7358.dtsi | 4 ++--
>  arch/mips/boot/dts/brcm/bcm7360.dtsi | 4 ++--
>  arch/mips/boot/dts/brcm/bcm7362.dtsi | 4 ++--
>  arch/mips/boot/dts/brcm/bcm7420.dtsi | 4 ++--
>  arch/mips/boot/dts/brcm/bcm7425.dtsi | 4 ++--
>  arch/mips/boot/dts/brcm/bcm7435.dtsi | 4 ++--
>  8 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/brcm/bcm7125.dtsi b/arch/mips/boot/dts/brcm/bcm7125.dtsi
> index dd1cc3cda694..81ee0f49b645 100644
> --- a/arch/mips/boot/dts/brcm/bcm7125.dtsi
> +++ b/arch/mips/boot/dts/brcm/bcm7125.dtsi
> @@ -250,8 +250,8 @@ qspi: spi@...000 {
>  			compatible = "brcm,spi-brcmstb-qspi",
>  				     "brcm,spi-bcm-qspi";
>  			clocks = <&upg_clk>;
> -			reg = <0x440920 0x4 0x443200 0x188 0x443000 0x50>;
> -			reg-names = "cs_reg", "hif_mspi", "bspi";
> +			reg = <0x443200 0x188 0x443000 0x50 0x440920 0x4>;
> +			reg-names = "hif_mspi", "bspi", "cs_reg";

So order is anyway broken by this change, thus you can as well rename it
to mspi, right?

Best regards,
Krzysztof