linux-kernel - Re: [PATCH] tools: lib: thermal: Correct CFLAGS and LDFLAGS in pkg-config template

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251226100946.14ad75d1@windsurf>
Date: Fri, 26 Dec 2025 10:09:46 +0100
From: Thomas Petazzoni <thomas.petazzoni@...tlin.com>
To: Romain Gantois <romain.gantois@...tlin.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano
 <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, Lukasz Luba
 <lukasz.luba@....com>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools: lib: thermal: Correct CFLAGS and LDFLAGS in
 pkg-config template

Hello Romain,

On Fri, 26 Dec 2025 08:54:32 +0100
Romain Gantois <romain.gantois@...tlin.com> wrote:

> diff --git a/tools/lib/thermal/libthermal.pc.template b/tools/lib/thermal/libthermal.pc.template
> index ac24d0ab17f5..3b8a24d0a8b8 100644
> --- a/tools/lib/thermal/libthermal.pc.template
> +++ b/tools/lib/thermal/libthermal.pc.template
> @@ -8,5 +8,5 @@ Name: libthermal
>  Description: thermal library
>  Requires: libnl-3.0 libnl-genl-3.0
>  Version: @VERSION@
> -Libs: -L${libdir} -lnl-genl-3 -lnl-3
> -Cflags: -I${includedir} -I${include}/libnl3
> +Libs: -L${libdir} -lnl-genl-3 -lnl-3 -lthermal
> +Cflags: -I${includedir} -I${includedir}/libnl3

Actually -lnl-genl-3 -lnl-3 in Libs and -I${includedir}/libnl3 in
Cflags can be removed as well, because the Requires: field contains
libnl-3.0 and libnl-genl-3.0, which will cause pkg-config to
recursively query the libs/cflags for libnl-3.0 and libnl-genl-3.0.

From https://people.freedesktop.org/~dbn/pkg-config-guide.html:

=====================================================================

Cflags: The compiler flags specific to this package and any required
libraries that don't support pkg-config. If the required libraries
support pkg-config, they should be added to Requires or
Requires.private.

Libs: The link flags specific to this package and any required
libraries that don't support pkg-config. The same rule as Cflags
applies here.

=====================================================================

Since libnl-3.0 and libnl-genl-3.0 support pkg-config (otherwise they
wouldn't be listed in Requires:), then those flags should be dropped
from Libs: and Cflags:.

Also, since this is a fix, probably this commit requires a Fixes: tag.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com