linux-kernel - Re: [PATCH 10/20] ublk: inline ublk_check_and_get_req() into ublk_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aU3uh3cAGEP6EJ1T@fedora>
Date: Fri, 26 Dec 2025 10:10:15 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>, Shuah Khan <shuah@...nel.org>,
	linux-block@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Stanley Zhang <stazhang@...estorage.com>,
	Uday Shankar <ushankar@...estorage.com>
Subject: Re: [PATCH 10/20] ublk: inline ublk_check_and_get_req() into
 ublk_user_copy()

On Tue, Dec 16, 2025 at 10:34:44PM -0700, Caleb Sander Mateos wrote:
> ublk_check_and_get_req() has a single callsite in ublk_user_copy(). It
> takes a ton of arguments in order to pass local variables from
> ublk_user_copy() to ublk_check_and_get_req() and vice versa. And more
> are about to be added. Combine the functions to reduce the argument
> passing noise.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>

Reviewed-by: Ming Lei <ming.lei@...hat.com>

Thanks,
Ming