linux-kernel - Re: [PATCH] PCI: Provide pci_free_irq_vectors() for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251226.201142.1049434388098064267.fujita.tomonori@gmail.com>
Date: Fri, 26 Dec 2025 20:11:42 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: boqun.feng@...il.com
Cc: fujita.tomonori@...il.com, miguel.ojeda.sandonis@...il.com,
 dakr@...nel.org, bhelgaas@...gle.com, ojeda@...nel.org, gary@...yguo.net,
 bjorn3_gh@...tonmail.com, lossin@...nel.org, a.hindborg@...nel.org,
 aliceryhl@...gle.com, tmgross@...ch.edu, joelagnelf@...dia.com,
 linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org, buaajxlj@....com
Subject: Re: [PATCH] PCI: Provide pci_free_irq_vectors() for CONFIG_PCI=n

On Thu, 25 Dec 2025 18:19:08 +0800
Boqun Feng <boqun.feng@...il.com> wrote:

> On Thu, Dec 25, 2025 at 06:36:31PM +0900, FUJITA Tomonori wrote:
>> On Thu, 25 Dec 2025 10:10:04 +0100
>> Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:
>> 
>> > On Mon, Dec 15, 2025 at 3:54 AM Boqun Feng <boqun.feng@...il.com> wrote:
>> >>
>> >> Commit 473b9f331718 ("rust: pci: fix build failure when CONFIG_PCI_MSI
>> >> is disabled") fixed a build error by providing rust helpers when
>> >> CONFIG_PCI_MSI=n. However the rust helpers rely on the
>> >> pci_alloc_irq_vectors() function is defined, which is not true when
>> >> CONFIG_PCI=n. There are multiple ways to fix this, e.g. a possible fix
>> >> could be just remove the calling of pci_alloc_irq_vectors() since it's
>> >> empty when CONFIG_PCI_MSI=n anyway. However, since PCI irq APIs, such as
>> >> pci_alloc_irq_vectors(), are already defined even when CONFIG_PCI=n, the
>> >> more reasonable fix is to define pci_alloc_irq_vectors() when
>> >> CONFIG_PCI=n and this aligns with the situations of other primitives as
>> >> well.
>> >>
>> >> Fixes: 473b9f331718 ("rust: pci: fix build failure when CONFIG_PCI_MSI is disabled")
>> >> Signed-off-by: Boqun Feng <boqun.feng@...il.com>
>> > 
>> > Related: https://lore.kernel.org/rust-for-linux/20251209014312.575940-1-fujita.tomonori@gmail.com/
>> > 
>> > I guess it counts as a report, so we may want a Reported-by (Cc'ing Tomo).
>> 
>> Since pci.rs is only compiled when CONFIG_PCI is enabled. So it seems
>> consistent to treat the PCI helpers the same way. That said, this
>> approach is also fine by me: it's already inconsistent that
>> pci_alloc_irq_vectors() has a stuf definition, while
>> pci_free_irq_vectors does not.
> 
> Yes, I think providing a stub pci_free_irq_vectors() is the way to go.
> If you are OK with it, I could send a v2 with your and Liang Jie's
> Reported-by.

It works for me. Please go ahead.