linux-kernel - Re: [PATCH] btrfs: tests: Fix memory leak in btrfs_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251226112455.1879731-1-zilin@seu.edu.cn>
Date: Fri, 26 Dec 2025 11:24:55 +0000
From: Zilin Guan <zilin@....edu.cn>
To: quwenruo.btrfs@....com
Cc: clm@...com,
	dan.carpenter@...aro.org,
	dsterba@...e.com,
	jianhao.xu@....edu.cn,
	linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	sunk67188@...il.com,
	zilin@....edu.cn
Subject: Re: [PATCH] btrfs: tests: Fix memory leak in btrfs_test_qgroups()

Hi Qu,

On Fri, Dec 26, 2025 at 06:33:34PM+1030, Qu Wenruo wrote:
> In that case it's correct to move the free_root immediately after 
> btrfs_insert_fs_root().
> 
> 
> And since you're here, you may also want to modify the error message of 
> the subvolume tree, it's copy-pasted from the fs root one, which is not 
> correct anymore (it's not fs tree but the first subvolume tree).

Thanks for the confirmation. I will update the error message accordingly in v2.

> > We have reviewed our previous submissions and found that most of them
> > have been accepted. Despite this, we will enforce stricter verification
> > processes in the future. Currently, our team enforces a strict
> > verification process: we manually confirm there is a clear path missing
> > a free before reporting a leak, and every patch undergoes a double-check
> > by at least two members.
> 
> If that's the case, please add them with proper tags.

Sure, I will include the related tags in v2.

Thanks,
Zilin Guan