linux-kernel - Re: [PATCH v4 1/2] dt-bindings: hwmon: add STEF48H28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFT9tykPEt+zTREF9C4AXtGp0qDh_65LjHZCK9F=NFhE-K4dGQ@mail.gmail.com>
Date: Fri, 26 Dec 2025 10:46:50 +0800
From: Yungteng Hsu <hsu.yungteng@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	devicetree@...r.kernel.org, Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: add STEF48H28

Krzysztof Kozlowski <krzk@...nel.org> 於 2025年12月24日週三 下午6:03寫道：
>
> On 24/12/2025 09:48, Charles Hsu wrote:
> > Add device tree bindings for the hot-swap controller STEF48H28.
> >
> > Signed-off-by: Charles Hsu <hsu.yungteng@...il.com>
> > ---
>
>
> Where is any changelog? You keep sending versions but you never
> responded, never said what happened with this.
>
Thank you for your feedback.
I realize now that I misunderstood the process.
I previously thought that the changes needed to be included in the cover letter.
I will follow the proper procedure for discussing updates in the thread.

> >  .../bindings/hwmon/pmbus/st,stef48h28.yaml    | 43 +++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> > new file mode 100644
> > index 000000000000..c6a4b02bcd84
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/st,stef48h28.yaml
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/st,stef48h28.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: STMicroelectronics hot-swap controller with PMBus interface
> > +
> > +maintainers:
> > +  - Charles Hsu <hsu.yungteng@...il.com>
> > +
> > +description: |
> > +  The STEF48H28 is an advanced 30A integrated electronic fuse for
> > +  the 9-80V DC power lines.
> > +
> > +  Datasheet:
> > +    https://www.st.com/resource/en/data_brief/stef48h28.pdf
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - st,stef48h28
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        pmic@11 {
>
> Your description says something else? Confusing.
Sorry for the confusion in the previous version, the datasheet link
was incorrect.
>
>
> > +            compatible = "st,stef48h28";
> > +            reg = <0x11>;
>
> You keep ignoring comments. Can you start responding to them?
I have updated the patch accordingly.
This device is not a regulator.
It is a power monitor, so regulator properties like supplies or
adjustable voltage are not applicable.
>
> NAK
>
> > +        };
> > +    };
>
>
> Best regards,
> Krzysztof