| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202512270457.MunhjmYM-lkp@intel.com>
Date: Sat, 27 Dec 2025 04:40:40 +0800
From: kernel test robot <lkp@...el.com>
To: Jiayuan Chen <jiayuan.chen@...ux.dev>, linux-mm@...ck.org,
akpm@...ux-foundation.org
Cc: oe-kbuild-all@...ts.linux.dev, Jiayuan Chen <jiayuan.chen@...pee.com>,
Johannes Weiner <hannes@...xchg.org>,
Michal Hocko <mhocko@...nel.org>,
Roman Gushchin <roman.gushchin@...ux.dev>,
Shakeel Butt <shakeel.butt@...ux.dev>,
Muchun Song <muchun.song@...ux.dev>,
Axel Rasmussen <axelrasmussen@...gle.com>,
Yuanchu Xie <yuanchu@...gle.com>, Wei Xu <weixugc@...gle.com>,
David Hildenbrand <david@...nel.org>,
Qi Zheng <zhengqi.arch@...edance.com>,
Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] mm/memcg: scale memory.high penalty based on refault
recency
Hi Jiayuan,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Jiayuan-Chen/mm-memcg-scale-memory-high-penalty-based-on-refault-recency/20251226-144331
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20251226064257.245581-1-jiayuan.chen%40linux.dev
patch subject: [PATCH v1] mm/memcg: scale memory.high penalty based on refault recency
config: nios2-allnoconfig (https://download.01.org/0day-ci/archive/20251227/202512270457.MunhjmYM-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251227/202512270457.MunhjmYM-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512270457.MunhjmYM-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from <command-line>:
mm/workingset.c: In function 'workingset_refault':
>> mm/workingset.c:570:33: error: invalid use of undefined type 'struct mem_cgroup'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~
include/linux/compiler_types.h:611:23: note: in definition of macro '__compiletime_assert'
611 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:631:9: note: in expansion of macro '_compiletime_assert'
631 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:60:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
60 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/workingset.c:570:17: note: in expansion of macro 'WRITE_ONCE'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~~~~~~~~~
>> mm/workingset.c:570:33: error: invalid use of undefined type 'struct mem_cgroup'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~
include/linux/compiler_types.h:611:23: note: in definition of macro '__compiletime_assert'
611 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:631:9: note: in expansion of macro '_compiletime_assert'
631 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:60:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
60 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/workingset.c:570:17: note: in expansion of macro 'WRITE_ONCE'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~~~~~~~~~
>> mm/workingset.c:570:33: error: invalid use of undefined type 'struct mem_cgroup'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~
include/linux/compiler_types.h:611:23: note: in definition of macro '__compiletime_assert'
611 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:631:9: note: in expansion of macro '_compiletime_assert'
631 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:60:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
60 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/workingset.c:570:17: note: in expansion of macro 'WRITE_ONCE'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~~~~~~~~~
>> mm/workingset.c:570:33: error: invalid use of undefined type 'struct mem_cgroup'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~
include/linux/compiler_types.h:611:23: note: in definition of macro '__compiletime_assert'
611 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:631:9: note: in expansion of macro '_compiletime_assert'
631 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:60:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
60 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/workingset.c:570:17: note: in expansion of macro 'WRITE_ONCE'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~~~~~~~~~
>> mm/workingset.c:570:33: error: invalid use of undefined type 'struct mem_cgroup'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~
include/linux/compiler_types.h:611:23: note: in definition of macro '__compiletime_assert'
611 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:631:9: note: in expansion of macro '_compiletime_assert'
631 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:60:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
60 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/workingset.c:570:17: note: in expansion of macro 'WRITE_ONCE'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~~~~~~~~~
In file included from ./arch/nios2/include/generated/asm/rwonce.h:1,
from include/linux/compiler.h:380,
from include/asm-generic/bug.h:5,
from ./arch/nios2/include/generated/asm/bug.h:1,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/current.h:6,
from ./arch/nios2/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/cgroup.h:12,
from include/linux/memcontrol.h:13,
from mm/workingset.c:8:
>> mm/workingset.c:570:33: error: invalid use of undefined type 'struct mem_cgroup'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~
include/asm-generic/rwonce.h:55:27: note: in definition of macro '__WRITE_ONCE'
55 | *(volatile typeof(x) *)&(x) = (val); \
| ^
mm/workingset.c:570:17: note: in expansion of macro 'WRITE_ONCE'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~~~~~~~~~
>> mm/workingset.c:570:33: error: invalid use of undefined type 'struct mem_cgroup'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~
include/asm-generic/rwonce.h:55:34: note: in definition of macro '__WRITE_ONCE'
55 | *(volatile typeof(x) *)&(x) = (val); \
| ^
mm/workingset.c:570:17: note: in expansion of macro 'WRITE_ONCE'
570 | WRITE_ONCE(memcg->last_refault, jiffies);
| ^~~~~~~~~~
vim +570 mm/workingset.c
529
530 /**
531 * workingset_refault - Evaluate the refault of a previously evicted folio.
532 * @folio: The freshly allocated replacement folio.
533 * @shadow: Shadow entry of the evicted folio.
534 *
535 * Calculates and evaluates the refault distance of the previously
536 * evicted folio in the context of the node and the memcg whose memory
537 * pressure caused the eviction.
538 */
539 void workingset_refault(struct folio *folio, void *shadow)
540 {
541 bool file = folio_is_file_lru(folio);
542 struct pglist_data *pgdat;
543 struct mem_cgroup *memcg;
544 struct lruvec *lruvec;
545 bool workingset;
546 long nr;
547
548 VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
549
550 if (lru_gen_enabled()) {
551 lru_gen_refault(folio, shadow);
552 return;
553 }
554
555 /*
556 * The activation decision for this folio is made at the level
557 * where the eviction occurred, as that is where the LRU order
558 * during folio reclaim is being determined.
559 *
560 * However, the cgroup that will own the folio is the one that
561 * is actually experiencing the refault event. Make sure the folio is
562 * locked to guarantee folio_memcg() stability throughout.
563 */
564 nr = folio_nr_pages(folio);
565 memcg = folio_memcg(folio);
566 pgdat = folio_pgdat(folio);
567 lruvec = mem_cgroup_lruvec(memcg, pgdat);
568
569 if (memcg)
> 570 WRITE_ONCE(memcg->last_refault, jiffies);
571
572 mod_lruvec_state(lruvec, WORKINGSET_REFAULT_BASE + file, nr);
573
574 if (!workingset_test_recent(shadow, file, &workingset, true))
575 return;
576
577 folio_set_active(folio);
578 workingset_age_nonresident(lruvec, nr);
579 mod_lruvec_state(lruvec, WORKINGSET_ACTIVATE_BASE + file, nr);
580
581 /* Folio was active prior to eviction */
582 if (workingset) {
583 folio_set_workingset(folio);
584 /*
585 * XXX: Move to folio_add_lru() when it supports new vs
586 * putback
587 */
588 lru_note_cost_refault(folio);
589 mod_lruvec_state(lruvec, WORKINGSET_RESTORE_BASE + file, nr);
590 }
591 }
592
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists