linux-kernel - Re:[PATCH] drm/bridge: synopsys: dw-dp: fix signedness bug in dw_dp_video_need_vsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59a2d3c0.51c.19b58194d04.Coremail.andyshrk@163.com>
Date: Fri, 26 Dec 2025 08:40:11 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Alper Ak" <alperyasinak1@...il.com>
Cc: andy.yan@...k-chips.com, "Andrzej Hajda" <andrzej.hajda@...el.com>,
	"Neil Armstrong" <neil.armstrong@...aro.org>,
	"Robert Foss" <rfoss@...nel.org>,
	"Laurent Pinchart" <Laurent.pinchart@...asonboard.com>,
	"Jonas Karlman" <jonas@...boo.se>,
	"Jernej Skrabec" <jernej.skrabec@...il.com>,
	"Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
	"Maxime Ripard" <mripard@...nel.org>,
	"Thomas Zimmermann" <tzimmermann@...e.de>,
	"David Airlie" <airlied@...il.com>,
	"Simona Vetter" <simona@...ll.ch>,
	"Dmitry Baryshkov" <dmitry.baryshkov@....qualcomm.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re:[PATCH] drm/bridge: synopsys: dw-dp: fix signedness bug in
 dw_dp_video_need_vsc_sdp()


Hi Alper,

At 2025-12-26 02:44:01, "Alper Ak" <alperyasinak1@...il.com> wrote:
>Since dw_dp_video_need_vsc_sdp() returns bool, have it return false
>instead of -EINVAL if state is NULL.
>
>Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
>Signed-off-by: Alper Ak <alperyasinak1@...il.com>


 Reviewed-by: Andy Yan <andyshrk@....com>

>---
> drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>index 82aaf74e1bc0..36382956bbe0 100644
>--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
> 
> 	state = dw_dp_get_bridge_state(dp);
> 	if (!state)
>-		return -EINVAL;
>+		return false;
> 
> 	if (!link->vsc_sdp_supported)
> 		return false;
>-- 
>2.43.0