[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20251227-regulators-defer-v1-1-3104b22d84cb@linaro.org>
Date: Sat, 27 Dec 2025 12:17:45 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Javier Martinez Canillas <javier@....samsung.com>,
Jon Hunter <jonathanh@...dia.com>, Dmitry Baryshkov <lumag@...nel.org>,
Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Peter Griffin <peter.griffin@...aro.org>,
Tudor Ambarus <tudor.ambarus@...aro.org>,
Will McVicker <willmcvicker@...gle.com>, Juan Yescas <jyescas@...gle.com>,
kernel-team@...roid.com, linux-kernel@...r.kernel.org,
André Draszik <andre.draszik@...aro.org>
Subject: [PATCH 1/8] regulator: core: update two debug messages
1)
In print_constraints_debug(), the power budget is printed as:
lldo2: 450 <--> 1300 mV at 900 mV 2147483647 mW budge, enabled
(note the missing t in budget). This is because there is a --count just
below the call to scnprintf(), to make space for the comma. All similar
calls to scnprintf() above add an extra space to the format string to
allow for that, but this one doesn't, so the last character t is
stripped instead. Update the format string to fix the message.
2)
Add the name of the supply to the failure message printed when the
supply can not be resolved when debug messages are enabled to help with
debug.
Signed-off-by: André Draszik <andre.draszik@...aro.org>
---
drivers/regulator/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 4b6182cde859adb356d160a012e54dcf1646da38..a723bd00e1716c2c3899c63314c6249015698216 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1183,7 +1183,7 @@ static void print_constraints_debug(struct regulator_dev *rdev)
count += scnprintf(buf + count, len - count, "standby ");
if (constraints->pw_budget_mW)
- count += scnprintf(buf + count, len - count, "%d mW budget",
+ count += scnprintf(buf + count, len - count, "%d mW budget ",
constraints->pw_budget_mW);
if (!count)
@@ -5697,7 +5697,8 @@ static int regulator_register_resolve_supply(struct device *dev, void *data)
struct regulator_dev *rdev = dev_to_rdev(dev);
if (regulator_resolve_supply(rdev))
- rdev_dbg(rdev, "unable to resolve supply\n");
+ rdev_dbg(rdev, "unable to resolve supply '%s'\n",
+ rdev->supply_name);
return 0;
}
--
2.52.0.351.gbe84eed79e-goog
Powered by blists - more mailing lists