lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251227-bipedal-wombat-of-correction-d71fd8@quoll>
Date: Sat, 27 Dec 2025 13:42:57 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Benoît Monin <benoit.monin@...tlin.com>
Cc: Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>, 
	Gregory CLEMENT <gregory.clement@...tlin.com>, Théo Lebrun <theo.lebrun@...tlin.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, 
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Tawfik Bayouk <tawfik.bayouk@...ileye.com>, 
	linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-clk@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v2 01/10] dt-bindings: soc: mobileye: Add EyeQ7H OLB

On Wed, Dec 24, 2025 at 11:07:14AM +0100, Benoît Monin wrote:
> +  '#reset-cells':
> +    description:
> +      First cell is domain and optional if compatible has a single reset domain.
> +      Second cell is reset index inside that domain.
> +    enum: [ 1, 2 ]
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 2
> +
> +  clock-names:
> +    minItems: 1
> +    maxItems: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#clock-cells'
> +  - clocks
> +  - clock-names
> +
> +additionalProperties: false

This goes before examples section.

> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mobileye,eyeq7h-ddr0-olb
> +              - mobileye,eyeq7h-ddr1-olb
> +              - mobileye,eyeq7h-mips0-olb
> +              - mobileye,eyeq7h-mips1-olb
> +              - mobileye,eyeq7h-mips2-olb
> +              - mobileye,eyeq7h-periph-east-olb
> +              - mobileye,eyeq7h-south-olb
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +          description:
> +            Reference input clock.

Just use items with description syntax, like everywhere else.

With these fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ