linux-kernel - Re: [PATCH v2] rust: cpumask: rename methods of Cpumask for clarity and consistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKBF=psYA77D4BbXch7=h3R5jbkpG0FgHH9XHC0DCg=n70480Q@mail.gmail.com>
Date: Sat, 27 Dec 2025 16:49:03 +0200
From: Kari Argillander <kari.argillander@...il.com>
To: Yilin Chen <1479826151@...com>
Cc: Viresh Kumar <viresh.kumar@...aro.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rust: cpumask: rename methods of Cpumask for clarity
 and consistency

On Fri, 26 Dec 2025 at 18:08, Yilin Chen <1479826151@...com> wrote:
>
> Rename `as_ref` and `as_mut_ref` to `from_raw` and `from_raw_mut` to
> align with the established naming convention for constructing types
> from raw pointers in the kernel's Rust codebase.
>
> Signed-off-by: Yilin <1479826151@...com>

Alice already pointed out this in v1 of the patch [1]. You need real name here.
So this probably needs be "Yilin Chen <...>". This also needs to be fixed in
other patches you have sent to the list.

[1]: https://lore.kernel.org/rust-for-linux/aUMUA_JWalyGQdAx@google.com/#t

> ---

This patch V2. Here after "---" you need to have changelog and usually it is
good idea to have link to old patch too. For new developers I personally suggest
to check b4 tool. That will make it easier to do new versions of patches.

Overall nice work and welcome to kernel Rust development.

    Argillander