linux-kernel - Re: [PATCH] rust: device_id: replace possible incorrect word in safety documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKBF=puTwJhNVhV=_N5m-dV8CRfkW8DpsAsC6i9zYxVZL_nQjQ@mail.gmail.com>
Date: Sat, 27 Dec 2025 17:01:58 +0200
From: Kari Argillander <kari.argillander@...il.com>
To: Yilin Chen <1479826151@...com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J . Wysocki" <rafael@...nel.org>, 
	Danilo Krummrich <dakr@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: device_id: replace possible incorrect word in
 safety documentation

Currently subject is

   [PATCH] rust: device_id: replace possible incorrect word in safety
documentation

After this is applied it does not make sense that there read "possible
incorrect". So just remove "possible" from subject.

On Fri, 26 Dec 2025 at 18:09, Yilin Chen <1479826151@...com> wrote:
>
> The safety documentation incorrectly refers to `RawDeviceId` when
> transmuting to `RawType`. This fixes the documentation to correctly
> indicate that implementers must ensure layout compatibility with
> `RawType`, not `RawDeviceId`.
>
> Signed-off-by: Yilin <1479826151@...com>

I have said in other patches already but just to be clear use real name
in signed-off-by line.

> ---

On v2 you will have something like this after "---":

Changes in v2:
- Changed subject (Kari Argillander)
- Use real name in signed-off-by line (Kari Argillander)
- Link to v1: https://lore.kernel.org/rust-for-linux/tencent_9F74630DC16B92484463BBC055DEB1F17306@qq.com/

> +++ b/rust/kernel/device_id.rs
> @@ -15,7 +15,7 @@
>  /// # Safety
>  ///
>  /// Implementers must ensure that `Self` is layout-compatible with [`RawDeviceId::RawType`];
> -/// i.e. it's safe to transmute to `RawDeviceId`.
> +/// i.e. it's safe to transmute to `RawType`.


    Argillander