linux-kernel - Re: [PATCH] ASoC: SDCA: Replace use of system_wq with system_percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd6c51c4-5371-4fd3-823a-eb1ecef24dc3@opensource.cirrus.com>
Date: Sat, 27 Dec 2025 15:14:45 +0000
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Marco Crivellari <marco.crivellari@...e.com>, linux-kernel@...r.kernel.org,
        linux-sound@...r.kernel.org, patches@...nsource.cirrus.com
Cc: Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Michal Hocko <mhocko@...e.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Maciej Strozek <mstrozek@...nsource.cirrus.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] ASoC: SDCA: Replace use of system_wq with
 system_percpu_wq

On 24/12/25 16:26, Marco Crivellari wrote:
> This patch continues the effort to refactor workqueue APIs, which has begun
> with the changes introducing new workqueues and a new alloc_workqueue flag:
> 
>     commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
>     commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
> 
> The point of the refactoring is to eventually alter the default behavior of
> workqueues to become unbound by default so that their workload placement is
> optimized by the scheduler.
> 
> Before that to happen after a careful review and conversion of each individual
> case

... so the commit message should say why this review decided that for
this individual case the best alternative queue was system_percpu_wq.

, workqueue users must be converted to the better named new workqueues with
> no intended behaviour changes:
> 
>     system_wq -> system_percpu_wq
>     system_unbound_wq -> system_dfl_wq
>

This seems to contradict the statement above that "after a careful
review .. of each individual case". This looks more like every system_wq
is converted to system_percpu_wq.