linux-kernel - Re: [PATCH v2] net/sched: Fix divide error in tabledist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVA4YJIT6at11JwH@pop-os.localdomain>
Date: Sat, 27 Dec 2025 11:49:52 -0800
From: Cong Wang <xiyou.wangcong@...il.com>
To: Manas <ghandatmanas@...il.com>
Cc: stephen@...workplumber.org, jhs@...atatu.com, jiri@...nulli.us,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net/sched: Fix divide error in tabledist

Hi Manas,

On Mon, Dec 22, 2025 at 11:43:06AM +0530, Manas wrote:
> Previously, a duplication check was added to ensure that a
> duplicating netem cannot exist in a tree with other netems. When
> check_netem_in_tree() fails after parameter updates, the qdisc
> structure is left in an inconsistent state with some new values
> applied but duplicate not updated. Move the tree validation check
> before modifying any qdisc parameters

We are reverting the check_netem_in_tree() code due to user-space
breakage. I hope reverting it could also fix the bug you repported here?

See: https://lore.kernel.org/netdev/20251227194135.1111972-3-xiyou.wangcong@gmail.com/

Thanks!
Cong