linux-kernel - Re: [PATCH 1/2] dt-bindings: display/msm/gpu: Narrow reg and reg-names for Adreno 610.0 and alike

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSVV03H_oii=fuhaeBhUZSJk-2mr08jGqAs30Z_h9tzeDgdtw@mail.gmail.com>
Date: Sat, 27 Dec 2025 14:01:27 -0800
From: Rob Clark <rob.clark@....qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Cc: Sean Paul <sean@...rly.run>, Konrad Dybcio <konradybcio@...nel.org>,
        Akhil P Oommen <akhilpo@....qualcomm.com>,
        Dmitry Baryshkov <lumag@...nel.org>,
        Abhinav Kumar <abhinav.kumar@...ux.dev>,
        Jessica Zhang <jesszhan0024@...il.com>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display/msm/gpu: Narrow reg and
 reg-names for Adreno 610.0 and alike

On Sat, Dec 27, 2025 at 3:05 AM Krzysztof Kozlowski
<krzysztof.kozlowski@....qualcomm.com> wrote:
>
> DTS files for qcom,adreno-610.0 and qcom,adreno-07000200 contain only one
> "reg" entry, not two, and the binding defines the second entry in
> "reg-names" differently than top-level part, so just simplify it and
> narrow to only one entry.

I'll defer to Akhil about whether this is actually needed (vs just
incomplete gpu devcoredump support for certain GPUs).  In general
cx_dbgc is needed to capture state for gpu devcoredump state
snapshots, but not directly used in normal operations.  It seems
similar to the situation with mapping gpucc as part of gmu, ie. not
something the CPU normally deals with directly, but necessary to
capture crash state.

BR,
-R

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> ---
>  Documentation/devicetree/bindings/display/msm/gpu.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> index 826aafdcc20b..1ae5faf2c867 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> @@ -378,11 +378,12 @@ allOf:
>              - const: xo
>                description: GPUCC clocksource clock
>
> +        reg:
> +          maxItems: 1
> +
>          reg-names:
> -          minItems: 1
>            items:
>              - const: kgsl_3d0_reg_memory
> -            - const: cx_dbgc
>
>        required:
>          - clocks
> --
> 2.51.0
>