linux-kernel - Re:Re: [PATCH v4 5/9] drm/bridge: add a driver for T-Head TH1520 HDMI controller

Open Source and information security mailing list archives

Message-ID: <5ce9d611.1868.19b5e9e7a61.Coremail.andyshrk@163.com>
Date: Sat, 27 Dec 2025 15:03:22 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Icenowy Zheng" <zhengxingda@...as.ac.cn>
Cc: "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
	"Maxime Ripard" <mripard@...nel.org>,
	"Thomas Zimmermann" <tzimmermann@...e.de>,
	"David Airlie" <airlied@...il.com>,
	"Simona Vetter" <simona@...ll.ch>, "Rob Herring" <robh@...nel.org>,
	"Krzysztof Kozlowski" <krzk+dt@...nel.org>,
	"Conor Dooley" <conor+dt@...nel.org>,
	"Drew Fustini" <fustini@...nel.org>, "Guo Ren" <guoren@...nel.org>,
	"Fu Wei" <wefu@...hat.com>, "Philipp Zabel" <p.zabel@...gutronix.de>,
	"Heiko Stuebner" <heiko@...ech.de>,
	"Andrzej Hajda" <andrzej.hajda@...el.com>,
	"Neil Armstrong" <neil.armstrong@...aro.org>,
	"Robert Foss" <rfoss@...nel.org>,
	"Laurent Pinchart" <Laurent.pinchart@...asonboard.com>,
	"Jonas Karlman" <jonas@...boo.se>,
	"Jernej Skrabec" <jernej.skrabec@...il.com>,
	"Michal Wilczynski" <m.wilczynski@...sung.com>,
	devicetree@...r.kernel.org, "Yao Zi" <ziyao@...root.org>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	"Han Gao" <rabenda.cn@...il.com>, linux-riscv@...ts.infradead.org
Subject: Re:Re: [PATCH v4 5/9] drm/bridge: add a driver for T-Head TH1520
 HDMI controller


Hello，

在 2025-12-26 21:27:53，"Icenowy Zheng" <zhengxingda@...as.ac.cn> 写道：
>在 2025-12-25星期四的 19:07 +0800，Andy Yan写道：
>> 
>> 
>> Hello Icenowy:
>> 
>> At 2025-12-25 00:12:01, "Icenowy Zheng" <zhengxingda@...as.ac.cn>
>> wrote:
>> > From: Icenowy Zheng <uwu@...nowy.me>
>> > 
>> > T-Head TH1520 SoC contains a Synopsys DesignWare HDMI controller
>> > (paired
>> > with DesignWare HDMI TX PHY Gen2) that takes the "DP" output from
>> > the
>> > display controller.
>> > 
>> > Add a driver for this controller utilizing the common DesignWare
>> > HDMI
>> > code in the kernel.
>> > 
>> > Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
>> > Signed-off-by: Icenowy Zheng <zhengxingda@...as.ac.cn>
>> > ---
>> > No changes in v3, v4.
>> > 
>> > Changes in v2:
>> > - Created a new function to set PHY parameters and refactored the
>> >  control flow of the configure_phy callback.
>> > 
>> > MAINTAINERS                             |   1 +
>> > drivers/gpu/drm/bridge/Kconfig          |  10 ++
>> > drivers/gpu/drm/bridge/Makefile         |   1 +
>> > drivers/gpu/drm/bridge/th1520-dw-hdmi.c | 173
>> > ++++++++++++++++++++++++
>> > 4 files changed, 185 insertions(+)
>> > create mode 100644 drivers/gpu/drm/bridge/th1520-dw-hdmi.c
>> 
>> 
>> As this is a Synopsys DesignWare based IP, maybe it's better to put
>> it under   "drivers/gpu/drm/bridge/synopsys/"
>> Or just create a dir for thead, I think there will come other display
>> related drivers for thead in the future.
>
>It's not proper to place vendor glues to synopsys/ .


TI has precedents for doing this with Cadence IP， see 

drivers/gpu/drm/bridge/cadence/cdns-dsi-j721e.c
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c 


>
>As for T-Head, they stopped their embedded SoC business (sold to
>another company) and now they only makes data-center chips, there
>should be no T-Head display drivers in the future.
>
>> 
>> 
>=========== 8< ============
>
>
>_______________________________________________
>linux-riscv mailing list
>linux-riscv@...ts.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives