linux-kernel - Re: [PATCH] Input: twl4030 - fix warnings without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cnh4xmnzegu4kcfqpfvuusgbhxml434ole5ew3ifkvlyuj66ub@6myllf7zll4k>
Date: Sat, 27 Dec 2025 01:25:14 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Andreas Kemnade <andreas@...nade.info>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] Input: twl4030 - fix warnings without CONFIG_OF

Hi Andreas,

On Mon, Dec 22, 2025 at 03:42:49PM +0100, Andreas Kemnade wrote:
> There are unused variables without CONFIG_OF:
> drivers/input/misc/twl4030-pwrbutton.c:41:44: error: unused variable 'twl4030_chipdata' [-Werror,-Wunused-const-variable]
>    41 | static const struct twl_pwrbutton_chipdata twl4030_chipdata = {
>       |                                            ^~~~~~~~~~~~~~~~
> drivers/input/misc/twl4030-pwrbutton.c:46:44: error: unused variable 'twl6030_chipdata' [-Werror,-Wunused-const-variable]
>    46 | static const struct twl_pwrbutton_chipdata twl6030_chipdata = {
> 
> Fix that by avoiding some #ifdef CONFIG_OF
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512220251.jDE8tKup-lkp@intel.com/
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>  drivers/input/misc/twl4030-pwrbutton.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index d82a3fb28d95..7468d0d3e97a 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -132,7 +132,6 @@ static void twl4030_pwrbutton_remove(struct platform_device *pdev)
>  	}
>  }
>  
> -#ifdef CONFIG_OF
>  static const struct of_device_id twl4030_pwrbutton_dt_match_table[] = {
>  	{
>  		.compatible = "ti,twl4030-pwrbutton",
> @@ -145,7 +144,6 @@ static const struct of_device_id twl4030_pwrbutton_dt_match_table[] = {
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, twl4030_pwrbutton_dt_match_table);
> -#endif

I think you should also remove use of of_match_ptr() and replace include
of.h with mod_devicetable.h.

Thanks.

-- 
Dmitry