linux-kernel - Re: [PATCH] drm/vmwgfx: Fix kernel-doc warnings for vmwgfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPqLRf1ZN3PWg3mzy5zV_2wfdk76-No4frkx_LTJN4tcyou0GA@mail.gmail.com>
Date: Sun, 28 Dec 2025 13:25:46 +0100
From: Bartłomiej Kubik <kubik.bartlomiej@...il.com>
To: zack.rusin@...adcom.com
Cc: bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org, 
	david.hunter.linux@...il.com, skhan@...uxfoundation.org, khalid@...nel.org, 
	linux-kernel-mentees@...ts.linux.dev, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] drm/vmwgfx: Fix kernel-doc warnings for vmwgfx_fence

Hi,

I submitted this patch about two weeks ago but haven't received any
feedback yet.
I wanted to check if there are any concerns with the patch or if any
changes are needed.

Please let me know if you need any additional information.

Best regards
Bartłomiej Kubik

On Thu, 11 Dec 2025 at 19:11, Bartlomiej Kubik
<kubik.bartlomiej@...il.com> wrote:
>
> Add missing descriptions for vmw_event_fence_action_seq_passed.
>
> This fixes the following warnings:
> drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:526 function parameter 'f'
>         not described in 'vmw_event_fence_action_seq_passed'
> drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:526 function parameter 'cb'
>         not described in 'vmw_event_fence_action_seq_passed'
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507040807.jKTxWGVQ-lkp@intel.com/
>
> Signed-off-by: Bartlomiej Kubik <kubik.bartlomiej@...il.com>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> index 00be92da5509..85795082fef9 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> @@ -515,12 +515,12 @@ int vmw_fence_obj_unref_ioctl(struct drm_device *dev, void *data,
>  /**
>   * vmw_event_fence_action_seq_passed
>   *
> - * @action: The struct vmw_fence_action embedded in a struct
> - * vmw_event_fence_action.
> + * @f: The struct dma_fence which provides timestamp for the action event
> + * @cb: The struct dma_fence_cb callback for the action event.
>   *
> - * This function is called when the seqno of the fence where @action is
> - * attached has passed. It queues the event on the submitter's event list.
> - * This function is always called from atomic context.
> + * This function is called when the seqno of the fence has passed
> + * and it is always called from atomic context.
> + * It queues the event on the submitter's event list.
>   */
>  static void vmw_event_fence_action_seq_passed(struct dma_fence *f,
>                                               struct dma_fence_cb *cb)
> --
> 2.39.5
>