linux-kernel - Re: [PATCH] soc: mediatek: SVS: Fix memory leak in svs_enable_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20dca540-1c20-460a-9079-718db465c518@web.de>
Date: Sun, 28 Dec 2025 15:19:00 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Jianhao Xu <jianhao.xu@....edu.cn>, Zilin Guan <zilin@....edu.cn>,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 Matthias Brugger <matthias.bgg@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH] soc: mediatek: SVS: Fix memory leak in
 svs_enable_debug_write()

…
> Fix this by freeing buf before returning the error code.

How do you think about to use the attribute “__free(kfree)”?
https://elixir.bootlin.com/linux/v6.19-rc2/source/include/linux/slab.h#L512
https://elixir.bootlin.com/linux/v6.19-rc2/source/drivers/soc/mediatek/mtk-svs.c#L785-L813

Regards,
Markus