linux-kernel - [PATCH] inode: move @isnew kdoc from inode_insert5 to ilookup5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251229-fix-kdoc-ilookup5_nowait-v1-1-60413f2723cf@gmail.com>
Date: Mon, 29 Dec 2025 01:04:07 +0900
From: Ryota Sakamoto <sakamo.ryota@...il.com>
To: Alexander Viro <viro@...iv.linux.org.uk>, 
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, 
 Mateusz Guzik <mjguzik@...il.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Ryota Sakamoto <sakamo.ryota@...il.com>
Subject: [PATCH] inode: move @isnew kdoc from inode_insert5 to
 ilookup5_nowait

The commit reworking I_NEW handling accidentally documented the @isnew
parameter in the kernel-doc for inode_insert5(), which does not take the
parameter. Meanwhile, ilookup5_nowait() gained the @isnew parameter but
lacked the corresponding kernel-doc.

Move the description to the correct function to ensure the kernel-doc
accuracy.

Fixes: a27628f43634 ("fs: rework I_NEW handling to operate without fences")
Signed-off-by: Ryota Sakamoto <sakamo.ryota@...il.com>
---
 fs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/inode.c b/fs/inode.c
index 521383223d8a455a2d09caff70615032213e3dfc..68056473d65ed4beba5241f4b1bac79b29cd84e9 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1278,7 +1278,6 @@ EXPORT_SYMBOL(unlock_two_nondirectories);
  * @test:	callback used for comparisons between inodes
  * @set:	callback used to initialize a new struct inode
  * @data:	opaque data pointer to pass to @test and @set
- * @isnew:	pointer to a bool which will indicate whether I_NEW is set
  *
  * Search for the inode specified by @hashval and @data in the inode cache,
  * and if present return it with an increased reference count. This is a
@@ -1593,6 +1592,7 @@ EXPORT_SYMBOL(igrab);
  * @hashval:	hash value (usually inode number) to search for
  * @test:	callback used for comparisons between inodes
  * @data:	opaque data pointer to pass to @test
+ * @isnew:	pointer to a bool which will indicate whether I_NEW is set
  *
  * Search for the inode specified by @hashval and @data in the inode cache.
  * If the inode is in the cache, the inode is returned with an incremented

---
base-commit: d26143bb38e2546fe6f8c9860c13a88146ce5dd6
change-id: 20251228-fix-kdoc-ilookup5_nowait-b17dc447bf2c

Best regards,
-- 
Ryota Sakamoto <sakamo.ryota@...il.com>