linux-kernel - Re: [PATCH 1/2] iio: imu: lsm6dsx: Support SMOCF05 ACPI ID for LSM6DS3TR-C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVFmec8JA6ZX18il@smile.fi.intel.com>
Date: Sun, 28 Dec 2025 19:18:49 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Samuel Dionne-Riel <samuel@...nne-riel.com>
Cc: Lorenzo Bianconi <lorenzo@...nel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: imu: lsm6dsx: Support SMOCF05 ACPI ID for
 LSM6DS3TR-C

On Mon, Dec 22, 2025 at 09:53:50PM -0500, Samuel Dionne-Riel wrote:
> Same device (LSM6DS3TR-C), different integration with the firmware.
> 
> The integration differs in that the firmware provides the SLA0 and SLG0
> mounting matrices. They are assumed to be Accelerometer and Gyroscope.
> 
> Observations were made against the Windows driver, version
> `12/06/2023,1.0.4.3`. This driver supports both identifiers, but expose
> the device in different ways.

...

>  static const struct acpi_device_id st_lsm6dsx_i2c_acpi_match[] = {
>  	{ "SMO8B30", ST_LSM6DS3TRC_ID, },
> +	{ "SMOCF05", ST_LSM6DS3TRC_ID, },

The trailing inner comma is redundant. Perhaps it would be nice to have
a cleanup patch to remove existing one.

>  	{ }
>  };

-- 
With Best Regards,
Andy Shevchenko